Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist hot key #1600

Closed
82d opened this issue Oct 7, 2021 · 11 comments
Closed

Wishlist hot key #1600

82d opened this issue Oct 7, 2021 · 11 comments

Comments

@82d
Copy link

82d commented Oct 7, 2021

I think it's very convenient to link the list to hotkeys. ctrl+w it will be convenient.

Nicotine+ 3.2.0.dev1
FreeBSD 12.2-RELEASE-p6

@82d 82d added the enhancement label Oct 7, 2021
@slook
Copy link
Member

slook commented Oct 7, 2021

It's Alt+W for the _Wishlist.
and Alt+S for Add / Remove Wi_sh

I am against using Ctrl+W because the shortcut is physically too close to Q on a qwerty keyboard which quits the program.

@82d
Copy link
Author

82d commented Oct 7, 2021

It's Alt+W for the _Wishlist. and Alt+S for Add / Remove Wi_sh

I am against using Ctrl+W because the shortcut is physically too close to Q on a qwerty keyboard which quits the program.

I agree, the combination of ctrl + w is not suitable. we need another combination.

@82d
Copy link
Author

82d commented Oct 7, 2021

can be done on only W

@slook
Copy link
Member

slook commented Oct 7, 2021

not really, because then it wouldn't activate if you were typing into one of the Filter text entry boxes. Also un-modified letter keys tend to be prone to causing conflicts.

we need another combination.

What's wrong with the current Alt+W shortcut binding?

@82d
Copy link
Author

82d commented Oct 7, 2021

you need to include this in the hotkey help. the topic can be closed. alt+W is normal.

@slook
Copy link
Member

slook commented Oct 7, 2021

Good idea, I will add both Alt+W and Alt+S into a new Wishlist category in the Keyboard Shortcuts window.

nicotine-plus Keyboard Shortcuts for Wishlist and User Browse

There are other shortcut changes in #1587 that I am waiting for @mathiascode to review/approve before I submit further changes to the Shortcuts window. As both these issues are low priority it might take a while. Thank you for your feedback on this.

@mathiascode
Copy link
Member

You can't hardcode Alt mnemonics in the shortcut window, since they aren't consistent across translations.

@slook
Copy link
Member

slook commented Oct 7, 2021

I suppose Alt+Return (File Properties) isn't affected by translations, but of course letters may well be. Thank you for pointing this out.

@82d
Copy link
Author

82d commented Oct 8, 2021

ctrl+F now a is displaying the filters line. what if it reassigns to Wishlist?

@mathiascode
Copy link
Member

ctrl+F now a is displaying the filters line. what if it reassigns to Wishlist?

This doesn't make sense. Ctrl+F should always triggers some form of search or filtering, not wishlist.

@slook
Copy link
Member

slook commented Oct 8, 2021

Ctrl+F should always triggers some form of search or filtering, not wishlist.

Agreed, I think the current Alt+W and Alt+S mnemonic shortcuts make sense the way it currently is. The solution would be to find a way of getting the accelerator programmatically for insertion into a tagged property within Shortcuts.ui at runtime, such as gtk-label-get-mnemonic-keyval() but I don't know how to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants