Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove wish not possible when search contains parens #1652

Closed
hboetes opened this issue Oct 27, 2021 · 1 comment
Closed

remove wish not possible when search contains parens #1652

hboetes opened this issue Oct 27, 2021 · 1 comment
Labels

Comments

@hboetes
Copy link
Member

hboetes commented Oct 27, 2021

zniavre noticed he could not remove the following wish:

autosearch = ['Every day people (feat. Proleter)'] 

I guess it has something to do with the parens.

@hboetes hboetes added the bug label Oct 27, 2021
@slook
Copy link
Member

slook commented Oct 27, 2021

Add Wish including parenthesis symbols is only possible from within the Wishlist dialog. However on testing this, it would seem that such items do not yield any results and no new Search Files Wish tab is ever created for them.

Usually in a normal search, symbols including parenthesis are stripped, which is why Remove Wish doesn't match the wish entry. However, it is possible to remove a Wish item from the Wishlist dialog, either with Remove Wish button in there or with Shift+Delete.

It makes me wonder if perhaps new Wishlist items should go through the symbol stripping procedure the same as new ordinary searches, or maybe it's better if they are stored as is but then stripped upon submitting each Wish search event (Edit: as is done with translate(self.translatepunctuation) but I don't know what unforeseen consequences of doing this might be).

mathiascode added a commit that referenced this issue Oct 27, 2021
We don't do this in any other lists anyway. Helps a bit with #1652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants