Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just crashed on Win 11 insider ring #1777

Closed
ztauras opened this issue Dec 22, 2021 · 2 comments
Closed

Just crashed on Win 11 insider ring #1777

ztauras opened this issue Dec 22, 2021 · 2 comments

Comments

@ztauras
Copy link

ztauras commented Dec 22, 2021

Type: <class 'ValueError'>
Value: access: embedded null character in path
Traceback: File "pynicotine/pynicotine.py", line 385, in network_event
File "pynicotine/pynicotine.py", line 1823, in queue_upload
File "pynicotine/transfers.py", line 666, in queue_upload
File "pynicotine/shares.py", line 646, in file_is_shared

@mathiascode
Copy link
Member

I assume this is on Nicotine+ 3.1.1? Do you share any files with names starting with "0 " (that would end up with a path similar to this: something\0 - test file.mp3)?

@mathiascode
Copy link
Member

I tried downloading a file containing "\0 " in the path with Soulseek NS, SoulseekQt and Nicotine+, and all of them escape the path properly. Either some other Soulseek client out there is misbehaving, or someone is sending invalid file paths with malicious intent. In any case, I've pushed a commit that handles such file paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants