Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for >2GB downloads #201

Closed
mathiascode opened this issue May 26, 2020 · 6 comments · Fixed by #328
Closed

Add support for >2GB downloads #201

mathiascode opened this issue May 26, 2020 · 6 comments · Fixed by #328

Comments

@mathiascode
Copy link
Member

mathiascode commented May 26, 2020

Support for large files was added to SoulseekQt in 2015, but parsing a TransferRequest response in Nicotine+ only returns 0 as the filesize for large files. Investigate what the official client does different.

Edit: Should also check if Museek+ supports large downloads.

@mathiascode
Copy link
Member Author

It is worth noting that large uploads seem to work just fine (tested with 16GB file).

@mathiascode
Copy link
Member Author

The only work left to do is to is to figure out why large downloads from SoulseekQt clients return a file size of 0. >2GB file transfers between Nicotine+ clients and uploads to SoulseekQt clients will work fine when Nicotine+ 2.0.0 is released.

@mathiascode
Copy link
Member Author

mathiascode commented Jun 28, 2020

Fully supported in #328, we just ignore the invalid file size sent by SoulseekQt.

Summary of changes:
b4304fa
1239785

@kiplingw
Copy link
Member

My guess is it probably involves a primitive whose width is too small to represent the value.

@mathiascode
Copy link
Member Author

What's also curious is that Nicotine+ correctly shows the size of >2GB files in search results, while SoulseekQt shows no size. SoulseekQt shows the correct size if you browse a user share though. :P

@mathiascode
Copy link
Member Author

Heh, now I realized that someone already came up with the same workaround in Museekd. eLvErDe/museek-plus@fd12d21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants