New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hidden directory files now showing up in file shares (Windows) #23
Comments
This is both a privacy/security issue and a hassle as to actually prevent sharing I'd have to move such a directory out of it's normal location. |
Could you check this branch : https://github.com/gfarmerfr/nicotine-plus/tree/fix-hidden-directories-windows ? |
It appears a required module wasn't included: ImportError: No module named win32file |
Yes I've just found it too. I had the 'pypiwin32' module installed which include win32file as a side effect of having pyinstaller on my Win7 box. |
I think for now it's adequate that .directory behavior is consistent across platforms and consistent with previous nicotine+ functionality: dot directories should be hidden. It would be good to have that modules functionality for the additional checking, but yes make it optional. |
Also if we eventually get to python 3.5 it looks a bit more straightforward without additional modules, see for example the is_hidden() here https://bugs.python.org/issue21719 |
Yes it would be easier for sure :) Thx for the link. Btw i've just updated the branch with the try/expect/else for the optional win32file. |
Hi @Mutnick Have you tested the refreshed branch ? For me it works fine. |
Yes this looks good, thanks. |
Done. Thx :) |
I have directories both with attrib +h and also that start with a dot. In the past this prevented sharing on both the official soulseek clients (which respect the attribute) and with nicotine+ (which in the past hid the .directories).
The hidden .directory files are now showing up in shares when running nicotine+ on windows.
The text was updated successfully, but these errors were encountered: