New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upnp functionality is used despite being config'd as False #24
Comments
Yes I can move this line at the start of the function that's not a problem. |
I've relocate the line at the top of the function OnFirstConnect() in frame.py. I've also found another line to relocate in the upnp.py init function:
This line was doing a NS lookup and i've pushed it back down to the function actually doing the port mapping so it's not called at initialization/check times. See https://github.com/gfarmerfr/nicotine-plus/commit/710621bc69ffb9179123bd94d0f5675996d0b208 in https://github.com/gfarmerfr/nicotine-plus/tree/avoid-unwanted-traffic-upnp |
The error occurs when resolving the host name. upnp = UPnPPortMapping() leading to the gethostbyname(gethostname()) is where the error occurs. On windows, gaierror: [Errno 11003] getaddrinfo failed I'll look into this further but the point remains that if someone doesn't want the upnp functionality for whatever reason, there is no need to be calling it at all. |
Just posted a few seconds ago :) |
Thank you, looks good. |
Merged into master. |
* Fix flake8 warnings * Mark remaining flake8 warnings with noqa comment * Update pipelines Co-authored-by: droserasprout <droserasprout@tuta.io> Co-authored-by: Lev Gorodetskiy <gorodetskiy@suicide.ventures>
In frame.py's OnFirstConnect function there are initializations and checks of upnp functionality even when upnp is configured as False (and such functionality is not desired or needed)
Please relocate
if self.np.config.sections["server"]["upnp"]:
to the very start of OnFirstConnect()
This is an issue as the reworked code broke the ability of the user to Torify Nicotine+.
The text was updated successfully, but these errors were encountered: