Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right-clicking file that user 2 downloads points to user 1 #297

Closed
hboetes opened this issue Jun 15, 2020 · 8 comments · Fixed by #298
Closed

right-clicking file that user 2 downloads points to user 1 #297

hboetes opened this issue Jun 15, 2020 · 8 comments · Fixed by #298
Labels

Comments

@hboetes
Copy link
Member

hboetes commented Jun 15, 2020

I sometimes check if people really share a nice collection or just a few dirs. So today two guys were downloading something. I right-clicked the username and checked his collection. After that I right-clicked on a file the second guy was downloading and in the menu I saw the name of Mr. 1. I had to click the username and then I got the right user.

@hboetes hboetes added the bug label Jun 15, 2020
@mathiascode
Copy link
Member

The general issue is that items aren't selected automatically when right-clicking them, right?

@hboetes
Copy link
Member Author

hboetes commented Jun 15, 2020

Yes, that's an accurate description of what I encountered. You have to left click something first before right clicking it.

@mathiascode
Copy link
Member

Can you test this branch?
git clone -b selection https://github.com/mathiascode/nicotine-plus

@hboetes
Copy link
Member Author

hboetes commented Jun 16, 2020

I'm testing the branch, how would you describe the change? I'm not sure what I should notice.

@mathiascode
Copy link
Member

mathiascode commented Jun 16, 2020

The behavior is modified in the search view, download list and upload list. If you right-click a row, it is now selected, and the popup menu appears. You can still select multiple rows by selecting an initial row, holding down shift, and selecting another one. If you then right-click a new row outside the selected ones, the previous rows will be unselected, and the new row will be selected instead.

(The behavior should be the same as most other programs with list/tree views)

@mathiascode
Copy link
Member

Make sure that these changes are in your local copy: mathiascode@a2b2062

@hboetes
Copy link
Member Author

hboetes commented Jun 16, 2020

Oh my, for some reason the branch did not get installed. Now it's working. Yes, much better! Thanks!

@mathiascode
Copy link
Member

Sweet, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants