Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In download page, pressing Delete key removes 2 files instead of 1 #314

Closed
zebulon-1st opened this issue Jun 21, 2020 · 8 comments
Closed
Labels

Comments

@zebulon-1st
Copy link

zebulon-1st commented Jun 21, 2020

Nicotine+ version: 1.4.3
branch master
downloaded from a "git clone"
always "git pull"ed before a new run.

Operating System/Distribution:
Debian GNU/Linux 9 (stretch) x86-64
Kernel: Linux 4.9.0-12-amd64

Describe the bug

In the download page, if I remove (by pressing Delete key) a file (finished or not), it is well removed. But the next file in list is removed too from the list.

Note : it does the same (2 files removed instead of 1) if I start from the very last file in list : the file before it is removed too.

@zebulon-1st zebulon-1st changed the title In download page, removing manually a file removes it and the next file too In download page, pressing Delete key removes 2 files instead of 1 Jun 21, 2020
@mathiascode
Copy link
Member

Does this happen consistently? I tested Nicotine+ on Debian 9, but couldn't reproduce the issue.

@zebulon-1st
Copy link
Author

Does this happen consistently?

It seems yes. It happened each times I would delete a file in the download list.

@mathiascode
Copy link
Member

Could you check if this branch solves the issue?

git clone -b deletekey https://github.com/mathiascode/nicotine-plus

@zebulon-1st
Copy link
Author

zebulon-1st commented Jun 23, 2020

Yes, absolutely. It seems solved.
I tried selecting the very first file only, and only the first file has been deleted.
I tried selecting the very last file only, and only the last file has been deleted.

But, another strange thing happens when I use CTRL to select here and there. Select a file, then press CTRL key twice, and the selection changes to the very last file in list. This not happens always.

And, globally, this version lags on GUI.

@mathiascode
Copy link
Member

Can you elaborate on the GUI lag issue? When exactly did it start happening? What kind of lag is it? Do you have many transfers in your download list (#34)?

@zebulon-1st
Copy link
Author

zebulon-1st commented Jun 23, 2020

It is perceptible as soon as this version of Nicotine+ (this branch) is launched. The graphical interface is slower to respond than with the version of the master branch.
Clicking on a tab (the search or downloads tab, for example) N+ takes a while before switching to it. Searching, downloading files from the search, ... In fact, any operation performed is slow to respond.
Otherwise, I have no other download in progress at the moment. There are only those (just a few audio files, about 10-15) chosen to test the problem with the Delete key.

@mathiascode
Copy link
Member

mathiascode commented Jun 23, 2020

Probably just a fluke, the changes in the deletekey branch shouldn't affect GUI performance. Mind trying the master branch again (the changes are included there now)?

@zebulon-1st
Copy link
Author

I retried with branch master (git pull'ed before, of course).
The issue seems to be fixed.
I tried deleting 1 file from the top, only the file selected removed.
I tried deleting 1 file from the bottom, only the file selected removed.
I tried selecting here and there, with CTRL key, selection unchanged, and only selection removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants