Can't find anything from Wu-tang

[hboetes]

I just searched for Legend Of The Wu-Tang which gave no results. Then I searched for Legend Of The Wu Tang — without the dash — and I did get results. What's going on here?

[mathiascode]

I don't think there's much that can be done here. The same thing happens in the official SoulseekQt client.

[hboetes]

Would it be an idea to replace - with spaces automatically? Maybe even replace some other characters like / and .

[mathiascode]

I'm not sure if it's a good idea, considering how much the results seem to change depending on which characters you include.

[hboetes]

Right, it's used to modify search results. https://www.slsknet.org/news/node/2855 as in search for everything wu but omit everything with tang. Rather sloppy coding if you'd ask me (on the slsk server side) since there is a clear difference between search -omit and jay-z, and any decent coder would fix that. Sigh closed source. :-(

Perhaps warn users if you'd search for [A-z]-[A-z]

[mathiascode]

@hboetes Could you test this PR? #368 (seems like SoulseekQt clients don't send search results if search terms include special characters, might be worth asking Nir what's up here)

git clone -b searchfilter https://github.com/mathiascode/nicotine-plus

[zniavre]

since the first day of this bug i can't reproduce it: with or without dash it found many files... Le mar. 7 juil. 2020 à 17:20, Mat <notifications@github.com> a écrit :

…

@hboetes <https://github.com/hboetes> Could you test this PR? #368 <#368> git clone -b searchfilter https://github.com/mathiascode/nicotine-plus — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#343 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASMI2UERI4Y6K2JKFZ6E4LR2M4NJANCNFSM4OOVJT3A> .

[mathiascode]

@zniavre Non-SoulseekQt clients send results if you include special characters, but SoulseekQt does not. If you search for something with a dash or apostrophe, you should notice that there are no results from SoulseekQt clients (their folders start with @@). This seems to be the behavior when searching inside the SoulseekQt client too.

[hboetes]

I just searched for wu-tang with your branch and repo and I got results (a few albums) then I searched with the master branch and repo and I got different results( a few loose tracks).

I like your version better. :-)

[mathiascode]

You can toggle the character filtering in settings -> searches, if desired. Searches without special characters in them should essentially be the same as searches with them, just with the addition of results from SoulseekQt clients.

[mathiascode]

Excluding words by placing - in front of them should work as long as they are clearly separated words.

[hboetes]

Yes, I like a lot. Could you sort search results by speed by default? :-) Or at least make clicking it sort decreasing instead of increasing? I always have to press that button twice.

slsk also sorts by speed by default.

[mathiascode]

I will defer the sorting change for now, since I had issues where the list would jump around a lot if you started scrolling when elements were still added.

[hboetes]

OK, I'll open a new ticket for it, so we won't forget.

Man I really love how don't have to worry about if a special char is accepted or not.