Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues to fix for 2.1.1 #659

Closed
3 tasks done
mathiascode opened this issue Sep 13, 2020 · 2 comments · Fixed by #682
Closed
3 tasks done

Minor issues to fix for 2.1.1 #659

mathiascode opened this issue Sep 13, 2020 · 2 comments · Fixed by #682
Labels

Comments

@mathiascode
Copy link
Member

mathiascode commented Sep 13, 2020

Due to personal time constraints, the next release(s) of Nicotine+ will be very small, unless there are contributions by other people. Here's a list of minor issues to fix for 2.1.1:

  • Ctrl+C no longer working in debug log window
  • In Settings -> Interface -> Icons, icon labels have the wrong order
  • Dev versions should not display "up to date" message in update checker

More issues will be added in due time.

@zniavre
Copy link
Contributor

zniavre commented Sep 13, 2020

i hav made change in setting window ui file to reorganize icon name>image how to send you this file please

https://pastebin.com/FDD9aJrF sorry for that :o)

not huge mod but at least i can "contribute" to nic+ after 17 years i will love to be one week contributor

@mathiascode
Copy link
Member Author

Thanks! Since you've only changed one file, you can get away with editing the file in the web UI by pressing the pencil icon here: https://github.com/Nicotine-Plus/nicotine-plus/blob/master/pynicotine/gtkgui/ui/settings/icons.ui

This will create a fork with the changed file. GitHub should then display a button for creating a pull request with the change.

If you plan on doing larger contributions that start touching the code, I recommend installing git and learning the basics. There should be multiple tutorials online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants