Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDG Base Directory Support #94

Closed
8wB5JyC8QoqtWJU8PYrxh4psxf8YPwgzn4zEI opened this issue Jul 31, 2019 · 7 comments
Closed

XDG Base Directory Support #94

8wB5JyC8QoqtWJU8PYrxh4psxf8YPwgzn4zEI opened this issue Jul 31, 2019 · 7 comments

Comments

@8wB5JyC8QoqtWJU8PYrxh4psxf8YPwgzn4zEI
Copy link

Please consider adopting the freedesktop.org standard.

This would reduce home directory pollution and follow the expected behavior of linux applications, which can also help with backup programs which ignore ~/.cache.

The change should be simple, generally it's just checking for the XDG base directory environmental variables, and if they don't exist, default to using ~/.config for configurations, and ~/.cache for cache. ~/.application_name should be avoided.
@gahag
Copy link
Contributor

gahag commented Oct 12, 2019

Can I work on this?

@eLvErDe
Copy link
Collaborator

eLvErDe commented Oct 12, 2019

Sure, if you're wiling to

@gahag
Copy link
Contributor

gahag commented Oct 12, 2019

Ok, in progress. Should be done by tomorrow, will hit you up if anything.

gahag added a commit to gahag/nicotine-plus that referenced this issue Oct 13, 2019
@gahag
Add GetUserDirectories function to support XDG Base Dir (nicotine-plu…
05456bf 
…s#94)

This implementation falls back to the legacy ~/.nicotine directory if it exists.
Otherwise, two new directories used:
- XDG_CONFIG_HOME/nicotine/: config files.
- XDG_DATA_HOME/nicotine/: database, plugins, logs, incomplete downloads, etc.
gahag added a commit to gahag/nicotine-plus that referenced this issue Oct 13, 2019
@gahag
Update modules to use the new directory schema, supporting XDG Base D…
5f847ae 
…ir (nicotine-plus#94)
@gahag gahag mentioned this issue Oct 13, 2019
Merged
kiplingw added a commit that referenced this issue Feb 15, 2020
@kiplingw
Merge pull request #98 from gahag/xdg
f0aaa44 
XDG Base Directory Support (#94)
@mathiascode
Copy link
Member

Issue should be closed.

@kiplingw
Copy link
Member

It should be, but for some reason I'm still seeing ~/.nicotine/ and not ~/.config/nicotine.

@mathiascode
Copy link
Member

~/.config/nicotine will only be created and used if the legacy ~/.nicotine/ folder isn't present.

@kiplingw
Copy link
Member

Yup. You are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kiplingw @eLvErDe @gahag @mathiascode @8wB5JyC8QoqtWJU8PYrxh4psxf8YPwgzn4zEI