Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Search Wishlist: Change "Select All" Button to "Clear All" #963

Closed
redactedscribe opened this issue Jan 22, 2021 · 3 comments

Comments

@redactedscribe
Copy link
Contributor

redactedscribe commented Jan 22, 2021

Describe the solution you'd like

The Select All button seems redundant: its purpose is only to select all and then press Remove. There is no other reason to select all items in the wishlist.

It'd be best suited to reorder these buttons to Remove and then a Clear All button, like is the convention elsewhere in the software. Obviously, the button should clear all and not select all now.

The Select All > Remove sequence may have been a shortcut to not implement Apply, Cancel, OK, as these would likely need to be present to make Clear All > Cancel a way to undo accidental clear-alls.

Additional context

An Add button isn't needed, as there is no need for a popup yet. This may change if wishlists network searches ever become more advanced, such as supporting predefined values for the result filter.

@mathiascode
Copy link
Member

We could make the behavior similar to the transfer statistics dialog - show a confirmation popup when attempting to clear all items. The Add button has already been removed in unstable.

@redactedscribe
Copy link
Contributor Author

redactedscribe commented Jan 22, 2021

That approach will work too. Simpler.

I hadn't noticed there was an Add button to begin with. I'm on unstable too.

@mathiascode
Copy link
Member

5b9c694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants