Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to reliably close search tabs via middle mouse button click #984

Closed
redactedscribe opened this issue Jan 31, 2021 · 3 comments
Closed
Labels

Comments

@redactedscribe
Copy link
Contributor

Nicotine+ version: Nicotine+ 3.0.0.dev1
Operating System/Distribution: Windows 10 20H2

Describe the bug

For some reason, attempting to close a search tab isn't reliable. It seems Nicotine+ can get stuck in some state where MMB clicking does nothing, until it does, and closing tabs is fine. Then, it won't work again. May also relate to tabs in general.

Expected behavior

100% success rate.

Steps to reproduce the bug

  1. Search for music.
  2. Attempt to close the music tab.
  3. May or may not succeed at closing the tab.

Additional context

Not sure if it's only related to MMB closing, or related to clicking the X button (which I have disabled from being shown).

@mathiascode
Copy link
Member

Does this only apply to search tabs? All I can think of is that the click may have been on the edges of the tab, where no signal handlers are connected.

@redactedscribe
Copy link
Contributor Author

I haven't used N+ for a while, but I do recall that the clicks were squarely in the middle of the search result tab. Not just a single click but many consecutive MMB clicks with no effect. I have moved the search tab bar to the left and so it's vertical, which may be relevant.

@mathiascode
Copy link
Member

Thanks, that makes sense. The label box (which catches the clicks) currently doesn't extend beyond the width of the text, so any empty space is affected by the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants