Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing a whole hard disk drive content doesn't work #999

Closed
ewauq opened this issue Feb 17, 2021 · 3 comments
Closed

Sharing a whole hard disk drive content doesn't work #999

ewauq opened this issue Feb 17, 2021 · 3 comments
Labels

Comments

@ewauq
Copy link

ewauq commented Feb 17, 2021

Nicotine+ version: 3.0.0
Operating System/Distribution: Windows 10 Professionnal 20H2

Describe the bug

Sharing an HDD from its root (like M:) doesn't share any file. I have to specify a folder (M:\Folk for example) to get the file sharing working properly.

So I have to add all folders at the HDD root one by one to share files.

The log console shows:

23:06:42 Rescanning normal shares...
23:06:43 0 folders found before rescan, rebuilding...
23:06:44 0 folders found after rescan

Expected behavior

Adding a HDD root folder shares all its folders and subfolders content.

Steps to reproduce the bug

  • Preferences > Transfers > Shares > Public Shares
  • Click Add... and select a HDD without selecting any of its folders
  • Give a Virtual Name (like Collection) and click OK

File scanning doesn't find any folder.

I wanted to show the process with a gif file but there is too many personnal data on the capture.

@ewauq ewauq added the bug label Feb 17, 2021
@mathiascode
Copy link
Member

It seems like Windows root directories have the FILE_ATTRIBUTE_HIDDEN attribute, which Nicotine+ respects. Perhaps we need to add a workaround for this special case.

@ewauq
Copy link
Author

ewauq commented Feb 18, 2021

Thank you for the answer. The current workaround is to share folders directly, so I can use Nicotine+, this is not a problem, I don't have a lot of folders. Glad to see you found the cause :)

@mathiascode
Copy link
Member

There was a bug where the root directory would be scanned, but not shared properly. This will be fixed in 3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants