Fix variable bitrate detection for MP3 files #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Mutagen commit 65d5910c12d9a4a4e0c7de0316b494ac064828c9 the code for detecting the VBR detection in nicotine is no longer working as it was using a private interface. In Mutagen commit 1ffd7dd97b145316b56ac7bd586a8ad8779d2b6d a public interface to detect the VBR for MP3 files was introduced. Use it by default and fallback to the old code in case an old version of Mutagen is in use.
ghost
merged commit 
|
Good catch :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Mutagen commit 65d5910c12d9a4a4e0c7de0316b494ac064828c9 the code
for detecting the VBR detection in nicotine is no longer working as it was
using a private interface.
In Mutagen commit 1ffd7dd97b145316b56ac7bd586a8ad8779d2b6d a public interface
to detect the VBR for MP3 files was introduced. Use it by default and fallback
to the old code in case an old version of Mutagen is in use.