From 1b0e67b68823cbba0fc418a2a59a8dff38b28d4f Mon Sep 17 00:00:00 2001
From: Nic Wortel <nic@nicwortel.nl>
Date: Thu, 15 Jun 2023 13:38:45 +0200
Subject: [PATCH] Configure sniffs for attributes

---
 NicWortel/ruleset.xml          |  4 ++++
 tests/correct/attributes.php   | 12 ++++++++++++
 tests/expected.csv             |  2 ++
 tests/incorrect/attributes.php | 13 +++++++++++++
 4 files changed, 31 insertions(+)
 create mode 100644 tests/correct/attributes.php
 create mode 100644 tests/incorrect/attributes.php

diff --git a/NicWortel/ruleset.xml b/NicWortel/ruleset.xml
index 522ea48..3eb5543 100644
--- a/NicWortel/ruleset.xml
+++ b/NicWortel/ruleset.xml
@@ -83,6 +83,10 @@
         </properties>
     </rule>
 
+    <!-- Force attributes to be directly above their target and disallow multiple attributes on 1 line -->
+    <rule ref="SlevomatCodingStandard.Attributes.AttributeAndTargetSpacing"/>
+    <rule ref="SlevomatCodingStandard.Attributes.DisallowMultipleAttributesPerLine"/>
+
     <!-- Disallow commented out code -->
     <rule ref="Squiz.PHP.CommentedOutCode"/>
 </ruleset>
diff --git a/tests/correct/attributes.php b/tests/correct/attributes.php
new file mode 100644
index 0000000..e7ba2ff
--- /dev/null
+++ b/tests/correct/attributes.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Foo;
+
+class Bar
+{
+    #[Attribute1]
+    #[Attribute2]
+    private string $foo;
+}
diff --git a/tests/expected.csv b/tests/expected.csv
index 5adb0e4..7ab5a4d 100644
--- a/tests/expected.csv
+++ b/tests/expected.csv
@@ -1,5 +1,7 @@
 "tests/incorrect/arrays.php",10,5,error,"Multi-line arrays must have a trailing comma after the last element.",SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma,5,1
 "tests/incorrect/arrays.php",5,20,error,"Short array syntax must be used to define arrays",Generic.Arrays.DisallowLongArraySyntax.Found,5,1
+"tests/incorrect/attributes.php",11,19,error,"Multiple attributes per line are disallowed.",SlevomatCodingStandard.Attributes.DisallowMultipleAttributesPerLine.DisallowedMultipleAttributesPerLine,5,1
+"tests/incorrect/attributes.php",9,5,error,"Expected 0 blank lines between attribute and its target, both are on same line.",SlevomatCodingStandard.Attributes.AttributeAndTargetSpacing.IncorrectLinesCountBetweenAttributeAndTarget,5,1
 "tests/incorrect/class-constant-visibility.php",9,5,error,"Visibility must be declared on all constants if your project supports PHP 7.1 or later",PSR12.Properties.ConstantVisibility.NotFound,5,0
 "tests/incorrect/commented-out-code.php",5,1,warning,"This comment is 50% valid code; is this commented out code?",Squiz.PHP.CommentedOutCode.Found,5,0
 "tests/incorrect/commenting.php",10,4,error,"Use of annotation @version is forbidden.",SlevomatCodingStandard.Commenting.ForbiddenAnnotations.AnnotationForbidden,5,1
diff --git a/tests/incorrect/attributes.php b/tests/incorrect/attributes.php
new file mode 100644
index 0000000..168154e
--- /dev/null
+++ b/tests/incorrect/attributes.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Foo;
+
+class Bar
+{
+    #[Attribute] private string $foo;
+
+    #[Attribute1] #[Attribute2]
+    private bool $bar;
+}