Add Automatic-Module-Name to support JPMS #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To permit modularized projects to access non-modular JARs, Java 9+ allows importing JAR files without a
module-info.classas "automatic modules".Per the ModuleFinder javadoc:
The automatic name generation without such an entry extracts the version information and then substitutes a dot for all non-alphanumeric characters. In the case of
code-assert-0.9.11.jarthe resulting module name iscode.assertwhich is illegal due to the reserved wordassert, making this project unusable as a module.This commit leverages the
maven-jar-pluginto generate a manifest file including a legalAutomatic-Module-Name.