Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile to build docker image with all dependencies. #22

Merged
merged 2 commits into from Apr 7, 2018

Conversation

JohanEngelen
Copy link
Collaborator

Image uploaded to hub.docker.com as jengelen/finitefield.

Hiermee wordt het testen veel sneller.
De GitlabCI tester is nu nog wel steeds stuk (maar die was al stuk door een recente verandering).

@niekbouman
Copy link
Owner

toevallig was ik net ook al met een dockerfile bezig, maar de jouwe ziet er netter uit! mooi werk!

Copy link
Owner

@niekbouman niekbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 't een idee om de build met ninja te doen, ipv make?
Of is dat juist goed om met make (een ander, meer gebruikt, buildsysteem) te testen

(dus ook "ninja-buil"d in de Docker image te installeren)

@niekbouman niekbouman merged commit 605af1d into master Apr 7, 2018
@JohanEngelen
Copy link
Collaborator Author

Ninja kan prima, is het zoveel sneller in dit geval?

@JohanEngelen JohanEngelen deleted the docker branch April 7, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants