Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/better type checking #57

Merged
merged 2 commits into from Feb 24, 2019

Conversation

Projects
None yet
2 participants
@nieldlr
Copy link
Owner

commented Feb 24, 2019

While building the HanziCraft react-native app, I noticed this line in the dictionarySearch was causing issues. It was evaluated as true by the react-native environment, which was bizarre. However, in theory the type checking done here was not very neat, so I changed it and fixed the bugs I was seeing. Still not sure why the non-empty search array == '' returned true in that environment. But that's probably going deep into different compilers/transpilers etc.

nieldlr added some commits Feb 24, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 24, 2019

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          15       15           
  Lines         548      548           
  Branches       91       91           
=======================================
  Hits          481      481           
  Misses         55       55           
  Partials       12       12
Impacted Files Coverage Δ
lib/dictionary.js 87.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99abbb0...a63b2c2. Read the comment docs.

@nieldlr nieldlr merged commit 8b80e6d into master Feb 24, 2019

3 checks passed

codecov/project 87.77% (+0%) compared to 99abbb0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@nieldlr nieldlr deleted the bug/better-type-checking branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.