Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug/better type checking #57
While building the HanziCraft react-native app, I noticed this line in the dictionarySearch was causing issues. It was evaluated as true by the react-native environment, which was bizarre. However, in theory the type checking done here was not very neat, so I changed it and fixed the bugs I was seeing. Still not sure why the non-empty search array == '' returned true in that environment. But that's probably going deep into different compilers/transpilers etc.
@@ Coverage Diff @@ ## master #57 +/- ## ======================================= Coverage 87.77% 87.77% ======================================= Files 15 15 Lines 548 548 Branches 91 91 ======================================= Hits 481 481 Misses 55 55 Partials 12 12