Local file issue and pip options #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added the PIP_OPTIONS to the pip upgrade call; otherwise the upgrade might fail if the user needs a special configuration to reach the package index (e.g. coproprate proxy...).
Owner
|
Hello @brogon, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you reference a local source file or directory, the script tries to "find" it in the temporary build directory, because it stripped the path. Also it won't work, if the user gave a relative path to the file. Therefore we convert the source path to an absolute one (if it's actually a local path) and handle it correctly.
Also added the PIP_OPTIONS to the pip upgrade call; otherwise the upgrade might fail if the user needs a special configuration to reach the package index (e.g. coproprate proxy... my nemesis... 😆).