Error when text.ejs or style.css not exists #1

Closed
yiyangest opened this Issue Jul 6, 2012 · 6 comments

Comments

Projects
None yet
4 participants
@yiyangest

It's occured an error when we don't have text.ejs or style.css under the templates dir.

It's seems like that fs.stat will throw an error when the file is not exists. BTW, I am under os x lion and using node 0.6.18.

@niftylettuce

This comment has been minimized.

Show comment Hide comment
@niftylettuce

niftylettuce Jul 11, 2012

Owner

Okay I can patch this, typically you'd want to have a text.ejs version. I don't believe style.css is a requirement though.

Owner

niftylettuce commented Jul 11, 2012

Okay I can patch this, typically you'd want to have a text.ejs version. I don't believe style.css is a requirement though.

@yiyangest

This comment has been minimized.

Show comment Hide comment
@yiyangest

yiyangest Jul 11, 2012

Yes, and in my scenario, it also get an error when I don't have the CSS
file.

Yes, and in my scenario, it also get an error when I don't have the CSS
file.

@samholmes

This comment has been minimized.

Show comment Hide comment
@samholmes

samholmes Aug 7, 2012

I notice this too. I was thinking, it would be great to be able to specify a style.css file for all templates. If I have a consistent style for all of my email templates, I still have to make a copy of the CSS file for each template folder. Maybe an API where you can set options and then just render ejs files would be better suited for this module.

The text.ejs file should be optional and dynamically generated when not present, IMO.

I notice this too. I was thinking, it would be great to be able to specify a style.css file for all templates. If I have a consistent style for all of my email templates, I still have to make a copy of the CSS file for each template folder. Maybe an API where you can set options and then just render ejs files would be better suited for this module.

The text.ejs file should be optional and dynamically generated when not present, IMO.

@jdrake

This comment has been minimized.

Show comment Hide comment
@jdrake

jdrake Sep 11, 2012

@samholmes

This comment has been minimized.

Show comment Hide comment
@samholmes

samholmes Sep 12, 2012

I was going to implement this in a fork of this project, which I was going to call mailplate. I might call it mailplatter or maildish instead. However, more importantly, it should allow you to choose the stylesheet you want to use for the template, but I haven't gotten around to this yet. xP

I was going to implement this in a fork of this project, which I was going to call mailplate. I might call it mailplatter or maildish instead. However, more importantly, it should allow you to choose the stylesheet you want to use for the template, but I haven't gotten around to this yet. xP

@niftylettuce

This comment has been minimized.

Show comment Hide comment
@niftylettuce

niftylettuce Sep 12, 2012

Owner

fix is in, thx guys, lmk if you have any other issues with this

Owner

niftylettuce commented Sep 12, 2012

fix is in, thx guys, lmk if you have any other issues with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment