New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ignoring styles.css without text.ejs #17

Merged
merged 1 commit into from Mar 4, 2013

Conversation

Projects
None yet
4 participants
@bratchenko
Contributor

bratchenko commented Nov 8, 2012

I believe it fixes #12

@niftylettuce

This comment has been minimized.

Show comment
Hide comment
@niftylettuce

niftylettuce Nov 16, 2012

we should write tests for these using assert or something to ensure css generated is accurate, i'll pull this in after i can confirm it fixes

niftylettuce commented on 8e637f3 Nov 16, 2012

we should write tests for these using assert or something to ensure css generated is accurate, i'll pull this in after i can confirm it fixes

@andrewrk

This comment has been minimized.

Show comment
Hide comment
@andrewrk

andrewrk Jan 3, 2013

Please merge this. We need the fix. Not having the fix is worse than not having tests.

andrewrk commented Jan 3, 2013

Please merge this. We need the fix. Not having the fix is worse than not having tests.

@niftylettuce

This comment has been minimized.

Show comment
Hide comment
@niftylettuce

niftylettuce Jan 3, 2013

Owner

Will do!
On Jan 3, 2013 4:46 PM, "Andrew Kelley" notifications@github.com wrote:

Please merge this. We need the fix. Not having the fix is worse than not
having tests.


Reply to this email directly or view it on GitHubhttps://github.com/niftylettuce/node-email-templates/pull/17#issuecomment-11862323.

Owner

niftylettuce commented Jan 3, 2013

Will do!
On Jan 3, 2013 4:46 PM, "Andrew Kelley" notifications@github.com wrote:

Please merge this. We need the fix. Not having the fix is worse than not
having tests.


Reply to this email directly or view it on GitHubhttps://github.com/niftylettuce/node-email-templates/pull/17#issuecomment-11862323.

@andrewrk

This comment has been minimized.

Show comment
Hide comment
@andrewrk

andrewrk Jan 3, 2013

If it doesn't work, I'll look at the code myself and write a fix and a test.

andrewrk commented Jan 3, 2013

If it doesn't work, I'll look at the code myself and write a fix and a test.

@micahlmartin

This comment has been minimized.

Show comment
Hide comment
@micahlmartin

micahlmartin Mar 4, 2013

is this 1 line of code ever going to get merged. I spent an hour trying to figure out why it wasn't working, fixed and submitted a pull request, then found this one. Would be nice to get it in.

micahlmartin commented Mar 4, 2013

is this 1 line of code ever going to get merged. I spent an hour trying to figure out why it wasn't working, fixed and submitted a pull request, then found this one. Would be nice to get it in.

niftylettuce added a commit that referenced this pull request Mar 4, 2013

Merge pull request #17 from daeq/patch-1
fixed ignoring styles.css without text.ejs

@niftylettuce niftylettuce merged commit 277995d into niftylettuce:master Mar 4, 2013

@niftylettuce

This comment has been minimized.

Show comment
Hide comment
@niftylettuce
Owner

niftylettuce commented Mar 4, 2013

@niftylettuce

This comment has been minimized.

Show comment
Hide comment
@niftylettuce

niftylettuce Mar 4, 2013

Owner

published 0.0.8

Owner

niftylettuce commented Mar 4, 2013

published 0.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment