Permalink
Browse files

release 0.0.7 - removes CSS minification b/c of final resulting incon…

…sistencies
  • Loading branch information...
1 parent 8116fcc commit 51a233d99756e8a98f2262cd6c07bbf2d9ad3728 @niftylettuce committed Sep 21, 2012
Showing with 57 additions and 7 deletions.
  1. +50 −0 .jshintrc
  2. +3 −1 Readme.md
  3. +3 −3 lib/main.js
  4. +1 −3 package.json
View
@@ -0,0 +1,50 @@
+{
+ "predef": [
+ "jasmine",
+ "spyOn",
+ "it",
+ "console",
+ "describe",
+ "expect",
+ "beforeEach",
+ "waits",
+ "waitsFor",
+ "runs",
+ "alert",
+ "confirm",
+ "Modernizr",
+ "impress",
+ "exports",
+ "self"
+ ],
+
+ "node" : true,
+ "es5" : true,
+ "browser" : true,
+ "jquery": true,
+
+ "boss" : false,
+ "curly": false,
+ "debug": false,
+ "devel": false,
+ "eqeqeq": true,
+ "evil": true,
+ "forin": false,
+ "immed": false,
+ "laxbreak": true,
+ "laxcomma": true,
+ "newcap": true,
+ "noarg": true,
+ "noempty": false,
+ "nonew": false,
+ "nomen": false,
+ "onevar": false,
+ "plusplus": false,
+ "regexp": false,
+ "undef": true,
+ "sub": true,
+ "strict": false,
+ "white": false,
+ "indent": 2,
+ "asi": true
+}
View
@@ -1,5 +1,7 @@
-# express-cdn <sup>0.0.6</sup>
+# express-cdn <sup>0.0.7</sup>
+
+**NOTE**: `0.0.7` removes CSS minification because `clean-css` module has conflicts with resulting CSS not getting process properly (e.g. it over-optimizes and removes things that were needed)
**NOTE**: `0.0.5` patches CSS single file in production mode and `0.0.6` adds temporary support for CSS usage of `background-image`, `background`, and `contents` attributes (the image paths must be absolute -- e.g. don't use `url: ("../whatever.png")`, instead use: `url: ("/whatever.png")`).
View
@@ -20,7 +20,6 @@ var fs = require('fs')
, zlib = require('zlib')
, async = require('async')
, request = require('request')
- , cleanCSS = require('clean-css')
, _ = require('underscore')
, jsp = require('uglify-js').parser
, pro = require('uglify-js').uglify
@@ -168,8 +167,9 @@ var compile = function(fileName, assets, S3, options, method, type, timestamp) {
});
break;
case 'minify':
- var minify = cleanCSS.process(results);
-
+ //var minify = cleanCSS.process(results);
+ // NOTE: We can't minify with cleanCSS because it has so many inconsistencies and invalid optimizations
+ var minify = results;
// Process images
minify.replace(/(background\-image|background|content)\:url\((?!data:)['"]?([^\)'"]+)['"]?\)/g, function (match, attribute, url) {
if (options.production) {
View
@@ -1,7 +1,7 @@
{
"name": "express-cdn"
, "description": "Node.js module for delivering optimized, minified, mangled, gzipped, and CDN-hosted assets in Express using S3 and CloudFront."
- , "version": "0.0.6"
+ , "version": "0.0.7"
, "author": "Nick Baugh <niftylettuce@gmail.com>"
, "contributors": [
{ "name": "Nick Baugh", "email": "niftylettuce@gmail.com" },
@@ -31,7 +31,6 @@
, "knox" : "https://github.com/niftylettuce/knox/tarball/master"
, "async" : "0.1.22"
, "request" : "2.9.203"
- , "clean-css" : "0.4.2"
, "uglify-js" : "1.3.2"
}
, "dependencies": {
@@ -42,7 +41,6 @@
, "knox" : "https://github.com/niftylettuce/knox/tarball/master"
, "async" : "0.1.22"
, "request" : "2.9.203"
- , "clean-css" : "0.4.2"
, "uglify-js" : "1.3.2"
}
}

0 comments on commit 51a233d

Please sign in to comment.