Navigation Menu

Skip to content
This repository has been archived by the owner on Mar 18, 2022. It is now read-only.

Files not versioning correctly #56

Closed
Nevtep opened this issue Nov 25, 2013 · 8 comments
Closed

Files not versioning correctly #56

Nevtep opened this issue Nov 25, 2013 · 8 comments

Comments

@Nevtep
Copy link
Contributor

Nevtep commented Nov 25, 2013

I'm seeing old versions of my js assets served from cloudfront and files in S3 don't have timestamps on their names anymore. S3 has the latest version thou cloudfront delivers old ones.

Any idea what could I be doing wrong? this is my config:

cdnOptions = {
publicDir: path.join(__dirname, 'public')
, viewsDir: path.join(__dirname, 'lib')
, domain: process.env.CDNHOST
, bucket: process.env.S3BUCKET
, key: process.env.AWSKEY
, secret: process.env.AWSSECRET
, hostname: 'staging.farmshares.com'
, port: 80
, ssl: false
, production: false
, logger: winston.info
};

@niftylettuce
Copy link
Collaborator

any luck?

@niftylettuce
Copy link
Collaborator

@Nevtep let me know!

@Nevtep
Copy link
Contributor Author

Nevtep commented Dec 5, 2013

Nope... just re-enabled cdn doing some tests... I cleared S3 before doing that ad everything seems updated... did cloudfront changed the way to lookup cached versions? files uploaded still don't have timestamps on their names

@Nevtep
Copy link
Contributor Author

Nevtep commented Dec 6, 2013

Nick still no timestamp on files, old versions appearing on cloudfront, any info that would help you know what's wrong?

@Nevtep
Copy link
Contributor Author

Nevtep commented Dec 7, 2013

Ok so, the filename?cache=timestamp sintax is not working for me, cloudfront is not returning the correct assets, in lines 118/125 you call createTag with a filename that is commented out to have the timestamp and use this ?cache=timestamp sintax, in the process assets method lines 460 and 468 are commented out to not include the timestamp on the names.

Is there anything about cloudfront config I should be doing to serve files correctly? it's serving old file versions for some reason.

Thanks

@Nevtep
Copy link
Contributor Author

Nevtep commented Dec 7, 2013

Ok found it!

  • Forward Query String: No (Improves Caching)

that should be YES since we are sending the cache timestamp on the query string

This is closed but you should update your documentation

@Nevtep Nevtep closed this as completed Dec 7, 2013
niftylettuce added a commit that referenced this issue Dec 7, 2013
@niftylettuce
Copy link
Collaborator

@Nevtep amazing find. you ROCK

@Nevtep
Copy link
Contributor Author

Nevtep commented Dec 8, 2013

@niftylettuce Thank you for this cool lib :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants