Allow using non US Standard S3 regions #23

Merged
merged 1 commit into from Nov 18, 2012

Conversation

Projects
None yet
3 participants
@eladb
Contributor

eladb commented Nov 14, 2012

When hosting data on non US Standard regions, S3 sometimes redirects requests (see
this for more details).

This change propagates the endpoint option to knox, which allows explicitly specifying the S3 endpoint.

Updated readme and sample.

Allow using non US Standard S3 regions
Added `options.endpoint` which is passed on to `knox` to allow
explicitly specifying the S3 endpoint.

Updated readme and sample.

niftylettuce added a commit that referenced this pull request Nov 18, 2012

Merge pull request #23 from urbancups/master
Allow using non US Standard S3 regions

@niftylettuce niftylettuce merged commit dba7e9d into niftylettuce:master Nov 18, 2012

@cjroebuck

This comment has been minimized.

Show comment Hide comment
@cjroebuck

cjroebuck Dec 6, 2012

I think this screws up if you omit the endpoint option (even though you are on US-standard). knox merges all options after setting endpoint internally.. so it gets clobbered and set to null. I was getting 502's from S3 all day wondering what was going on.

I think this screws up if you omit the endpoint option (even though you are on US-standard). knox merges all options after setting endpoint internally.. so it gets clobbered and set to null. I was getting 502's from S3 all day wondering what was going on.

@niftylettuce

This comment has been minimized.

Show comment Hide comment
@niftylettuce

niftylettuce Dec 6, 2012

Owner

@cjroebuck can you add a patch for us? thanks for reporting

Owner

niftylettuce commented Dec 6, 2012

@cjroebuck can you add a patch for us? thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment