New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perlcritic issues #14

Merged
merged 3 commits into from Jun 25, 2017

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Jun 14, 2017

This pull request gets the dist to pass the basic level of perlcritic checks. Some test files were missing the strict pragma, some needed to use the three-argument form of the open statement, and some were using bareword filehandles. These issues have been fixed in this PR.

If you have any questions or comments, please don't hesitate to contact me!

@nigelm nigelm self-assigned this Jun 25, 2017

@nigelm

This comment has been minimized.

Show comment
Hide comment
@nigelm

nigelm Jun 25, 2017

Owner

Integrating

Owner

nigelm commented Jun 25, 2017

Integrating

@nigelm nigelm merged commit af37c6b into nigelm:master Jun 25, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment