New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide New Viewer Greeting broken #3060

Closed
Daisenki opened this Issue Apr 6, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@Daisenki

Daisenki commented Apr 6, 2018

Hide New Viewer Greeting does not work anymore (Firefox 59.0.2 - BTTV Version 7.2.18 (Apr 3, 2018))

say hi
on

@Senpos

This comment has been minimized.

Contributor

Senpos commented Apr 13, 2018

@Daisenki
Hiding this promotion was not implemented before and is not implemented in the fix above.
It is not easy to catch this popup, but will try my best.

@night night closed this in #3066 Apr 15, 2018

@Nareese

This comment has been minimized.

Contributor

Nareese commented Apr 17, 2018

Unfortunately, .user-notice-line is used by more than just the new viewer greeting. It is also used minimally by subscription announcements, leading to the report in #3071. I don't know what the right fix for this is at this point. As near as I can see, it's yet another case of twitch removing a unique identifier from something and leaving it unable to be differentiated from other things.

@Senpos

This comment has been minimized.

Contributor

Senpos commented Apr 17, 2018

@Nareese Oh, Lord.
Well, probably we should use message text to determine if it's "greeting" or not.

Shame on you, Twitch :(

Thanks for informing, @Nareese

night added a commit that referenced this issue May 29, 2018

Change ritual hiding to generic chat events handler (#3111)
Add additional chat events handling to fix ritual hiding, and implement subscription hiding.  Replaces the hide_new_viewer_greeting module which twitch broke by making the CSS class on rituals the same as other notices.

Fixes #3060
Fixes #3104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment