Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG doesn't play music #302

Closed
darealshinji opened this issue Jun 24, 2014 · 10 comments

Comments

Projects
None yet
3 participants
@darealshinji
Copy link
Contributor

commented Jun 24, 2014

I've just downloaded the source and compiled it. NG runs but it doesn't play any music. The version currently installed on my system works fine however (Git snapshot from 2014-05-24).
Here's the output from the error console:

Fehler: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [sbIMediacoreSequencer.playView]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://songbird/content/bindings/playlist.xml :: sendPlayEvent :: line 1616"  data: no]

My system: Linux Mint 17, x86_64 Linux 3.13.0-27-generic

@freaktechnik

This comment has been minimized.

Copy link
Member

commented Jun 24, 2014

Interesting. The NS_ERROR_UNEXPECTED has to come from somewhere deeper down the stack, starting here: https://github.com/nightingale-media-player/nightingale-hacking/blob/sb-trunk-oldxul/components/mediacore/manager/src/sbMediacoreSequencer.cpp#L2725.
If you're building it yourself, could you try a debug build (With ac_add_options --enable-debug) and run it from the console?

@darealshinji

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2014

Downloaded latest git snapshot and made a debug build.
Here's the error console output:

Warnung: assignment to undeclared variable item
Quelldatei: file:///home/djcj/Downloads/nightingale-hacking-sb-trunk-oldxul/compiled/dist/extensions/mpris@getnightingale.com/platform/Linux_x86_64-gcc3/components/ngMprisService.js
Zeile: 1453

Fehler: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [sbIMediacoreSequencer.playView]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://songbird/content/scripts/mainPlayerWindow.js :: onPlay :: line 419"  data: no]
Quelldatei: chrome://songbird/content/scripts/mainPlayerWindow.js
Zeile: 426

Fehler: sbCommands.xml - menu - onMenuCommand - [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [sbIMediacoreSequencer.playView]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://songbird/content/bindings/playlist.xml :: sendPlayEvent :: line 1616"  data: no]
Quelldatei: chrome://songbird/content/bindings/sbCommands.xml
Zeile: 1131

And the shell output logged via tee: https://www.sendspace.com/file/bj0209

@freaktechnik

This comment has been minimized.

Copy link
Member

commented Jun 25, 2014

Hm, the first error is interesting. Fixed that, so it shouldn't happen anymore...

@freaktechnik

This comment has been minimized.

Copy link
Member

commented Jun 25, 2014

I think I'm guilty of this. WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /home/djcj/Downloads/nightingale-hacking-sb-trunk-oldxul/components/mediacore/base/src/sbBaseMediacoreMultibandEqualizer.cpp, line 196
Could you confirm that everything works as expected on a new profile but not on an existing one? Because that's what I'm guessing is the problem here.
EDIT: actually, switching to english will fix it on your existing profile. The issue here is, that eq presets added a few new strings, some of them are required to run ngale, but the language bundles haven't been updated yet (looks at @GeekShadow).

@darealshinji

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2014

It works only with language set to English. Even if I delete my config folder and start a new profile, as soon as the language is changed to German, the music won't play anymore.

@freaktechnik

This comment has been minimized.

Copy link
Member

commented Jun 25, 2014

Yeah, that's because the language bundles aren't updated yet. You can work around this by changing the EQ preset once (even if you reset it to flat). After that you will be able to play music even when ngale isn't set to english.
EDIT: just a clearification, this is because we want the default preset to be localized, so it's called "Flach" in german, for example.

@darealshinji

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2014

I found out that EQ presets located in components/equalizerpresets isn't installed when I build NG.

@freaktechnik

This comment has been minimized.

Copy link
Member

commented Jul 2, 2014

I am pretty sure they are, but again they probably can't find the strings, as the default set is localizable and thus needs additional strings (well, technically the strings are already there, but as dtd and the implementation needs them in a properties file). I am pretty sure the components are installed properly, see the ngDefaultPresetProvider.js and similar in compiled/dist/components.

@freaktechnik freaktechnik added this to the 1.12.2 milestone Jul 15, 2014

@darealshinji

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2015

I've never had any issues like this again.

@freaktechnik

This comment has been minimized.

Copy link
Member

commented Aug 3, 2015

This should still happen with non-english langpacks, unless @AntoineTurmel since built langpacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.