-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum Safety Threshold
update
#260
Conversation
- Changes default of minimum safety threshold to `60` from `65` to match standard oref. - Changes name of setting from `Threshold Setting (mg/dL)` to `Minimum Safety Threshold (mg/dL)`. - Updates tooltip to improve clarity.
LGTM! |
Minor suggestion for improvement (?), as it may not be clear what the “If you use mmol” part actually means: Must be set between 60-120 mg/dL. If you use mmol/L, multiply by 18 -> Must be set between 60-120 mg/dL. To convert from mmol/L to mg/dL, please multiply by 18 |
"If you use mmol/L," -> "To convert from mmol/L," Co-Authored-By: bjornoleh <63544115+bjornoleh@users.noreply.github.com>
10dcb23
to
fb97b13
Compare
Thanks. Just pushed that update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging with two approving reviews |
`Minimum Safety Threshold` update
60
from65
to match standard oref.20 + ½ TargetGlucose
. Since 80 mg/dL is the lowest oref will use as a target, 60 mg/dL is the lowest oref will set the safety threshold to.Threshold Setting (mg/dL)
toMinimum Safety Threshold (mg/dL)
.