Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Day to day" Report does not show requested days and is stuck in "Rendering" #3659

Closed
2flea opened this issue Jul 2, 2018 · 31 comments

Comments

@2flea
Copy link

@2flea 2flea commented Jul 2, 2018

image

Since some days I cannot run the "day to day" reports any longer for a date range. It does not show all days requested but stops in "Rendering" status. Screenshot is for last 2 days but this happens also for last week or last 2 weeks. All days except the last or last two are rendered and shown correctly.

This worked successfully before but since two days I have this issue - maybe it is data related?!

Nightscout
version 0.10.2-release-20171201
head

Browser tested:
Chrome Version 67.0.3396.99 (Offizieller Build) (64-Bit)
Firefox Version 61.0 (64-Bit)
Safari Version 11.1.1

@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Jul 2, 2018

Seems to be related with profile switches. I switched on 29.06. and on 01.07. and if one of these days is in the report range this issue occurs.

@sulkaharo

This comment has been minimized.

Copy link
Member

@sulkaharo sulkaharo commented Jul 8, 2018

Can you retry with latest test please?

@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Jul 8, 2018

Tried latest dev branch without success.

screenshot 2018-07-08 20 52 16

screenshot 2018-07-08 20 52 35

@PieterGit

This comment has been minimized.

Copy link
Contributor

@PieterGit PieterGit commented Jul 8, 2018

@2flea can you tell me which Node version you are using and what kind of hosting (Azure, Heroku, Self hosted, etc.)

@PieterGit

This comment has been minimized.

Copy link
Contributor

@PieterGit PieterGit commented Jul 8, 2018

Tagging this for 0.10.3 version, but because this will be released soon, this might not make it in time.

@PieterGit PieterGit added this to the 0.10.3 milestone Jul 8, 2018
@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Jul 9, 2018

Heroku hosting:
~/node_modules $ npm version
{ Nightscout: '0.10.2-release-20171201',
npm: '5.3.0',
ares: '1.10.1-DEV',
cldr: '31.0.1',
http_parser: '2.7.0',
icu: '59.1',
modules: '57',
nghttp2: '1.25.0',
node: '8.9.4',
openssl: '1.0.2n',
tz: '2017b',
unicode: '9.0',
uv: '1.15.0',
v8: '6.1.534.50',
zlib: '1.2.11' }

@sulkaharo

This comment has been minimized.

Copy link
Member

@sulkaharo sulkaharo commented Jul 9, 2018

If the process gets stuck on Rendering, that should mean the client has successfully loaded all the data and gets stuck on some data issue. Can you open the Javascript console on your browser when you get this, and see if there's errors logged?

@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Jul 9, 2018

There is the following error displayed from "profilefunctions.js" line 266

image

On 01.07. I did a profile switch, if I include this day I get the above problem/error, if I exclude it no problem with the displaying.

@quizzmaster

This comment has been minimized.

Copy link

@quizzmaster quizzmaster commented Jul 18, 2018

I'm using version 0.10.3-dev-20180708 getting the following error if a profile switch occured within a requested day:
TypeError: e is undefined bundle.js:16:684377

@PieterGit

This comment has been minimized.

Copy link
Contributor

@PieterGit PieterGit commented Aug 5, 2018

Can you retry with the 0.10.3 release. We didn't make it fixing this for the 0.10.3 release. Let's see if we can fix this with Nightscout 0.11

@PieterGit PieterGit modified the milestones: 0.10.3, 0.11.0 Aug 5, 2018
@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Aug 5, 2018

Master 0.10.3 did not fix it. I tried 0.10.3 dev before also without success.

@viq

This comment has been minimized.

Copy link

@viq viq commented Sep 29, 2018

I can confirm I'm still seeing something at least very similar on today's dev.

@Unvollendet8

This comment has been minimized.

Copy link

@Unvollendet8 Unvollendet8 commented Oct 14, 2018

Is there a workaround for that? Because I'm experiencing the exact same problem and I did a lot profile switches the last days for different reasons.

@PieterGit

This comment has been minimized.

Copy link
Contributor

@PieterGit PieterGit commented Oct 14, 2018

@Unvollendet8 I don't know of any workaround and don't have the possibility to do profileSwitches at this moment.

The error @2flea lists in #3659 (comment) comes from this line:
https://github.com/nightscout/cgm-remote-monitor/blame/dev/lib/profilefunctions.js#L266
which has been in the code for over a year. Perhaps @MilosKozak can help us out what's wrong with the profileswitches.

@vickster1

This comment has been minimized.

Copy link

@vickster1 vickster1 commented Oct 15, 2018

I’m seeing something similar, but with other weird behaviour. My site keeps being unresponsive, so trying to edit my profile takes forever & sometimes I can’t get the new values to load at all. My homepage keeps briefly showing the correct TBR data from AAPS, but then flicks back to a page showing only very recent TBR data & otherwise showing my standard basal profile.
With reports, I tried picking the last month’s data to view day by day. It took a long time to respond & then the date range reverted to the last week & only today & yesterday were shown. At this point the ‘show’ button has disappeared, so even if I try to change the date range or report type, I can’t. Whatever date range I try, it reverts back to the last week. Distribution doesn’t work at all.
Have any other users noticed this other odd behaviour associated with the reports issue?

@PieterGit

This comment has been minimized.

Copy link
Contributor

@PieterGit PieterGit commented Oct 24, 2018

@2flea @quizzmaster @viq @Unvollendet8 @vickster1 I can't reproduce this. Could you update your site to the latest dev (requires with Node 8.12.0) and confirm if you can reproduce it there. Please also mention your setup (cgm, aps, uploader type, etc.). We need more information to be able to squash this bug.

Please also check your browser console window and server console/log for possible errors.

@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Oct 24, 2018

@PieterGit just tested with latest dev "0.11.0-dev-20181022" including Node 8.12.0. I cannot reproduce the issue neither. I ran the day-to-day report for the time from 01.07.2018 till today which includes several profile switches (Original problem was 01.07.2018-02.07.2018). The report appears after some time with all days displayed. Looks OK to me.
G6, XDrip (latest Nightly), Dana RS, AAPS (latest Dev)
I tested with Chrome (Version 70.0.3538.67 (Offizieller Build) (64-Bit)) on a MacBook Pro.

@PieterGit

This comment has been minimized.

Copy link
Contributor

@PieterGit PieterGit commented Oct 24, 2018

@2flea thanks for the report. I looked to all the changes, see https://github.com/nightscout/cgm-remote-monitor/pull/4022/files . Perhaps it was caused by "mongodb": "~3.0.11", which is now upgraded to `"mongodb": "^3.1.8"``

I hope others can confirm this is fixed for the upcomping 0.11 release. Otherwise, we need to dig deeper.

@Unvollendet8

This comment has been minimized.

Copy link

@Unvollendet8 Unvollendet8 commented Oct 25, 2018

@PieterGit thanks for the testing. I'd like to give some feedback as well, but I don't know how to update to the latest dev. Sorry. Is there any wiki where I can find it? Thanks in advance.

Edit: Updated to the newest master, if I want to update to the latest dev I get a lot of errors as an output. So I updated the latest master (deployed on heroku) and I'm exeriencing still the same issue.

I set up my heroku to automatically update when the repository is updated. I guess I'll wait for 0.11, currently I'm using 0.10.3-master-20180805.

Just for clarification: Every time I switch profiles over AAPS, it appears that if I want to show my "day to day" reports (with graphics and stuff) I can only see everything from the day I switched my profile.

Regards

@vickster1

This comment has been minimized.

Copy link

@vickster1 vickster1 commented Oct 29, 2018

I'm using Dex G5, AAPS master 1.58, xdrip latest master 2018.09.08, Dana RS & heroku. I don't have experience in computer science, so don't tend to test any dev versions. I'm using Nighscout v0.10.3-master-20180805.
I know how to update to the latest dev, but don't know how to check my Node number or change it.
I have Node.js listed as my framework on my heroku dashboard, but no number.

@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Oct 29, 2018

I know how to update to the latest dev, but don't know how to check my Node number or change it.

You need to open the console in Heroku and open a bash shell. Then type "npm version".
If you'd upgrade to latest dev it would include the update of node.js .

@sulkaharo

This comment has been minimized.

Copy link
Member

@sulkaharo sulkaharo commented Oct 29, 2018

#4031 might fix this - if you can pull the PR and test, that'd be awesome

@sulkaharo

This comment has been minimized.

Copy link
Member

@sulkaharo sulkaharo commented Oct 29, 2018

@PieterGit Debugged this with one user and for her the issue was a Profile Change event that didn't have a profile at all, causing a crash on the line I if'd out ^^

@sulkaharo

This comment has been minimized.

Copy link
Member

@sulkaharo sulkaharo commented Oct 30, 2018

I pushed the fix to DEV branch - if everyone here could test if the reporting works now and write back, that'd be awesome

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Oct 30, 2018

I pushed the fix to DEV branch - if everyone here could test if the reporting works now and write back, that'd be awesome

Thank you very much mate, everything is working fine now!

I had the same problems as stated above (using the latest master branch) , deployed the newest dev branch and voilà the "day to day" reports appear in its entirety (even after profile switches).

My setup: Dana RS, Dexcom G6, latest dev AAPS, xDrip+ and Nightscout 0.11.0-dev-20181022.

Thanks for the support!

Cheers.

@sulkaharo

This comment has been minimized.

Copy link
Member

@sulkaharo sulkaharo commented Oct 30, 2018

@neothem do you think you could provide logs from AAPS to @MilosKozak so we could check if the problematic profile events are originating from AAPS?

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Oct 30, 2018

@sulkaharo Sure, no problem. Should I send the logs via mail to the stated mail adress which can be found in AAPS under maintenance?

@vickster1

This comment has been minimized.

Copy link

@vickster1 vickster1 commented Nov 1, 2018

I have updated to dev 0.11.0 & can now see reports again - thanks a lot for helping!

But...there are still issues. Do you want me to open a new issue about these?

  1. My Nightscout page flicks back & forth between showing all TBRs & only showing TBRs from the last 3 hours (and also not showing sage or cage).
  2. Profile edits are very temperamental. The profile edit page is often unresponsive, and I can be part way through a profile edit when the page reverts back to a different profile with no option to change it.
  3. After loading a report, the date at the top reverts back to the last 7 days & both ‘day to day’ button and the ‘distribution’ button which I had chosen are both highlighted. To then choose a different report/date I have to reload the page. It’s not a huge issue, but thought you might want to know.
    3853f179-d9f7-48bc-ac92-b22f7f669fe1
    36788166-b02c-4bb5-9b13-94418a3bfac1
@2flea

This comment has been minimized.

Copy link
Author

@2flea 2flea commented Nov 5, 2018

@PieterGit @sulkaharo Shall/Can I close the issue? Or do you need any more tests and confirmations by other users?

@sulkaharo

This comment has been minimized.

Copy link
Member

@sulkaharo sulkaharo commented Nov 5, 2018

Given there's a confirmation it's fixed from multiple users, maybe close. If you can create new tickets about the other issues, that'd be great. :)

@2flea 2flea closed this Nov 5, 2018
@candreassen

This comment has been minimized.

Copy link

@candreassen candreassen commented Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.