/cgm-remote-monitor

Port profile api from wip/iob-cob #439

Merged
merged 3 commits into from Mar 8, 2015
+84 −10

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.7.0 (Enchilada)
3 participants
@jasoncalabrese @coveralls @dduugg
@jasoncalabrese
Owner

jasoncalabrese commented Feb 26, 2015

This PR is to make it easier to bring some of the work @MilosKozak to the mainline and to prepare for adding and option to enable IOB in the mainline

Jason Calabrese added some commits Sep 25, 2014

@jasoncalabrese Jason Calabrese forgot to git add some profile api files ea1dbcc
@jasoncalabrese Jason Calabrese no POSTs yet 7653ef5
@jasoncalabrese Jason Calabrese more cherry-picking and porting of the profile api/storage from iob-cob

All checks have passed

3 successful checks
continuous-integration/codeship — Build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
6080f67

jasoncalabrese added the in progress label Feb 26, 2015

@coveralls

coveralls commented Feb 26, 2015

Coverage Status

Coverage increased (+0.33%) to 71.15% when pulling 6080f67 on wip/enable-profile into d616b6c on dev.

jasoncalabrese referenced this pull request Mar 1, 2015

Merged

Add an option to enable IOB in the mainline #452

@jasoncalabrese
Owner

jasoncalabrese commented Mar 1, 2015

Need to add IOB tests

@dduugg dduugg commented on the diff Mar 1, 2015

View full changes
lib/websocket.js
@@ -188,8 +190,19 @@ function update() {
treatment.x = timestamp.getTime();
return treatment;
});
- // all done, do loadData
- loadData( );
+
+ profiles.list(function (err, results) {
+ // There should be only one document in the profile collection with a DIA. If there are multiple, use the last one.
+ results.forEach(function(element, index, array) {
+ if (element) {
+ if (element.dia) {
@dduugg

dduugg Mar 1, 2015

Contributor

Lines 197-198 could be simplified to if (element && element.dia) {, correct?

Also, consider a standard for loop that goes backward from the end of results, and breaks when it finds element.dia.

@dduugg dduugg commented on the diff Mar 1, 2015

View full changes
lib/websocket.js
@@ -237,6 +250,10 @@ function loadData() {
});
}
+ if (profileData) {
@dduugg

dduugg Mar 1, 2015

Contributor

Is this ever false? (an empty array is truthy).
@jasoncalabrese
Owner

jasoncalabrese commented Mar 1, 2015

@dduugg this was a quick port from the iob-cob branch, was planning on doing some cleanup, not sure if that happens here or with #452

jasoncalabrese referenced this pull request Mar 7, 2015

Closed

A system DEFAULTS env var #440

@jasoncalabrese jasoncalabrese merged commit 6080f67 into dev Mar 8, 2015
3 checks passed

3 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

jasoncalabrese removed the in progress label Mar 8, 2015

@jasoncalabrese jasoncalabrese modified the milestone: enchilada Mar 18, 2015

jasoncalabrese changed the title from Page to enter and view a treatment profile to Port profile api from wip/iob-cob Mar 18, 2015

jasoncalabrese referenced this pull request Apr 19, 2015

Merged

Release 0.7.0 (Enchilada) #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment