Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update portalguide.md #284

Merged
merged 2 commits into from Nov 5, 2021
Merged

Update portalguide.md #284

merged 2 commits into from Nov 5, 2021

Conversation

fridayek
Copy link
Collaborator

Updated with Portal changes.

Updated with Portal changes.
@ACharbonneau
Copy link
Contributor

@raynamharris Could you review this please? It's updated docs for the new UI you're looking at.

Copy link
Contributor

@raynamharris raynamharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I was able to follow along, and it seems that all the changes point the reader to the appropriately named tabs and such that have been changed in the latest revision. I only found one typo in a URL path that needs to be corrected.

@@ -21,7 +21,7 @@ The specific goals of the CFDE are to:

### Purpose of this Document

The CFDE website includes two modules to ensure the specific goals are met and users can find data—the [portal](https://app.nih-cfde.org/) and the [dashboard](https://app.nih-cfde.org/dashboard.html). This document describes those modules in detail. The goals of both the portal and the dashboard are to establish FAIR data production by:
The CFDE website includes two modules to ensure the specific goals are met and users can find data—the [portal](https://app.nih-cfde.org/) and the [dashboard](https://https://app.nih-cfde.org/udashboard.html). This document describes those modules in detail. The goals of both the portal and the dashboard are to establish FAIR data production by:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new path has https:// repeated twice, so it is invalid. As a side note, https://app.nih-cfde.org/dashboard.html redirects to the appropriate https://app.nih-cfde.org/udashboard.html so that's good

@raynamharris
Copy link
Contributor

As I was reviewing this PR, I thought, I really should've read this before I started clicking buttons and blinding exploring the data. Yes, this document is easily accessed from the "User Help" drop-down menu, but I didn't really notice that at first. Thus, I suggested providing a link to the User Guide in dib-lab/cfde-helpdesk#8

@raynamharris
Copy link
Contributor

@ACharbonneau I'm happy to merge this and then fix the hyperlink in a separate PR if that helps

@ACharbonneau
Copy link
Contributor

@raynamharris could you merge and do the hyperlink in a new one? Since the new portal is live it would be good to have the right docs linked :)

@ACharbonneau
Copy link
Contributor

could you figure out the other two PRs as well? It looks like they're supposed to be adding images to this one

@raynamharris raynamharris merged commit d04c95b into stable Nov 5, 2021
@raynamharris raynamharris deleted the fridayek-patch-1 branch November 5, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants