Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes library function colors, PHP tag colors and PHP variable colors, Makefile targets #6

Merged
merged 3 commits into from Dec 27, 2015

Conversation

michaelneu
Copy link
Contributor

I really like your theme, but I think some things were missing, so here's a PR with some suggestions:

  • For starters, I missed the highlighted library functions. In Visual Studio some library functions are highlighted in purple, so I added this
  • The different background color of an embedded source (e.g. PHP inside HTML) annoyed me as it was really distracting for me (removed it)
  • I added colors to the PHP tags in general, so they better fit in with other tags
  • When working on a bigger web project you'll notice that the $ in JS is marked as an operator (keyword.operator.js), but PHP variables aren't. I liked the look of it, so I added this for PHP variables too.
  • Makefile targets were not highlighted (I set them to be the same color as class definitions)

@michaelneu michaelneu changed the title Fixes library function colors, PHP tag colors and PHP variable colors Fixes library function colors, PHP tag colors and PHP variable colors, Makefile targets Dec 27, 2015
@nikeee nikeee merged commit 4feb13c into nikeee:master Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants