Testcases Discussion

[nikgalanop]

Some notes about the testcases that mr. Sagonas sent us:

• 103-ar.eds: Have not seen that thoroughly yet. (Hopefully solved by dce21b9.)
• 129-fwd.eds: We've previously assumed that we only need to declare functions in our CG Symbol Table only for linking purposes (thus for declarations in the outer scope). This is not true when some nested declarations are involved in mutual recursion. (Solved by aea13b9.)
• #61
• 160-qsort.eds:
  1. We've assumed that we cannot compare characters, with the way we've interpreted the language specification. This is not the main issue. (Changed nothing.)
  2. The problem is that the functions qsort(...) & doqsort(...) accept a pointer to a string-like (constant string or array of characters). However, these functions are called with a constant string as an argument. It makes sense that doqsort results in Segmentation Fault when the program attempts to alter the contents of that (constant in this case) string-like. I believe that our compiler behaves properly. (Changed nothing.)
• 164-rel.eds: Same issue pretty much with 160-qsort.eds. We've assumed that we cannot compare characters. (Changed nothing.)

[nikgalanop]

A comment about 149-new.eds. It does not make sense for us to flush stdin before readString. The programmer should discard any tokens they don't need. (Look at a similar issue: f06a960 and the corresponsing magic squares correction: c7e0e4e.)

[nikgalanop]

Should I close this issue @el18177 ?