Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Merge pull request #384 from mattjphillips/remove_app_optimization

Remove problematic optimization for local base class properties.
  • Loading branch information...
commit 4bf7585034f58c74ce2b5b3c77e6b623914ca0e4 2 parents 28cdf6f + 87cc02e
@nikhilk authored
View
8 src/Core/Compiler/Generator/ExpressionGenerator.cs
@@ -860,13 +860,7 @@ internal static class ExpressionGenerator {
Debug.Assert(baseClass != null);
writer.Write(baseClass.FullGeneratedName);
- if (baseClass.IsApplicationType) {
- writer.Write("$.");
- }
- else {
- writer.Write(".prototype.");
- }
- writer.Write("get_");
+ writer.Write(".prototype.get_");
writer.Write(expression.Property.GeneratedName);
writer.Write(".call(");
writer.Write(generator.CurrentImplementation.ThisIdentifier);
View
2  tests/TestCases/Expression/Members/Baseline.txt
@@ -67,7 +67,7 @@ define('test', ['ss'], function(ss) {
test2: function() {
var n = this.get_XYZ();
n = this.get_XYZ();
- n = App$.get_XYZ.call(this);
+ n = App.prototype.get_XYZ.call(this);
this.set_XYZ(n);
this.set_XYZ(n);
ss.base(this, 'set_XYZ').call(this, n);
View
2  tests/TestCases/Member/Properties/Baseline.txt
@@ -41,7 +41,7 @@ define('test', ['ss'], function(ss) {
function Test2() {
Test.call(this);
- var n = Test$.get_XYZ.call(this);
+ var n = Test.prototype.get_XYZ.call(this);
if (n === this.get_XYZ()) {
}
if (this.get_XYZ() === n) {
Please sign in to comment.
Something went wrong with that request. Please try again.