Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Custom resolver system outside of taglib #28

Open
nikhilm opened this Issue · 0 comments

1 participant

@nikhilm
Owner

The current mutex based system works, but it has one significant taglib level shortcoming that FileTypeResolver takes only filenames and not IOStream.

In addition, the requirement that no v8 activity occurs in a worker thread requires hacks like the mutex one currently in place. This is obviously not fun, and at some point I want to allow resolvers themselves to notify the format via a callback. Finally reading and writing from buffers using BufferStream means that JS resolvers should be able to get a buffer as an argument.

So we need our own system, that will trigger the callbacks sequentially whenever a read is attempted, then use the format string to create the right File wrapping the BufferStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.