Fix linker error (on Mac OS 10.5.8) #37

Merged
merged 1 commit into from Sep 16, 2012

Projects

None yet

2 participants

@lmjohns3

I've been getting the following linker error when trying to npm install node-taglib :

i686-apple-darwin9-g++-4.0.1: -install_name only allowed with -dynamiclib

I finally tracked down the code in node-gyp that was generating the linker arguments in the makefiles, and it looks like it just needed augmenting with a -dynamiclib in the LDFLAGS.

@nikhilm
Owner
nikhilm commented Sep 16, 2012

On my snow leopard system with g++ 4.2.1 it works without the flag. But I'm merging this since adding the flag doesn't seem to cause any problems on my system.

@nikhilm nikhilm merged commit f8e531b into nikhilm:master Sep 16, 2012
@theopolisme theopolisme added a commit to theopolisme/node-taglib that referenced this pull request Apr 17, 2014
@theopolisme theopolisme Remove -dynamiclib flag
Introduced in #37 as a cosmetic improvement for some specific systems, the dynamiclib flag results in the following error on Mac OS 10.9.2:

    clang: error: invalid argument '-bundle' not allowed with '-dynamiclib'

Removing it resolves the error.
fea01d8
@theopolisme theopolisme referenced this pull request Apr 17, 2014
Merged

Remove -dynamiclib flag #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment