More pretty print tests - #232
Closed
AydinHassan wants to merge 2 commits into
Closed
Conversation
Owner
There was a problem hiding this comment.
The $ here is missing a variable name -- that's probably what's causing the issue.
The error message in the test is really bad though, that should be done better...
AydinHassan
force-pushed
the
more-pretty-print-tests
branch
from
October 1, 2015 16:01
21dfa54 to
2188234
Compare
Author
|
@nikic Fixed and updated the PR description, now excuse me while I go back to page 1 in my PHP book 😭 |
Owner
|
Thanks for the tests! That brings pretty printer coverage to 91% :) |
Author
|
Thanks 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I was using the
PrinterPrinterfor something and noticed that a lot of the code was not tested, so I decided to add some tests. See 818cc6.I also added a multi init for loop parser test. See 2188234.