Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type vs string #732

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Fixed type vs string #732

merged 1 commit into from
Dec 3, 2020

Conversation

quisse
Copy link

@quisse quisse commented Nov 7, 2020

Php parses { as an array [0 => 386,1 => '{',2 => 12,] so this check doesn't work properly. My edit fixes this.

@quisse
Copy link
Author

quisse commented Nov 8, 2020

Proof can be seen here https://3v4l.org/WRjDC

@quisse quisse force-pushed the quisse-tokentype-fix branch 2 times, most recently from 0300270 to 41274bd Compare November 8, 2020 13:44
@quisse quisse requested a review from nikic November 8, 2020 13:45
@quisse quisse force-pushed the quisse-tokentype-fix branch 3 times, most recently from ddd477d to a8d83d7 Compare November 8, 2020 14:23
@quisse
Copy link
Author

quisse commented Nov 8, 2020

Tests are succeeding. Could you have another look please?

@quisse quisse requested a review from nikic November 25, 2020 19:11
@nikic nikic merged commit c64986f into nikic:master Dec 3, 2020
@quisse quisse deleted the quisse-tokentype-fix branch December 3, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants