diff --git a/llvm/docs/InstCombineContributorGuide.md b/llvm/docs/InstCombineContributorGuide.md index 2416fd0920f62..51d04dd074c56 100644 --- a/llvm/docs/InstCombineContributorGuide.md +++ b/llvm/docs/InstCombineContributorGuide.md @@ -554,3 +554,11 @@ guidelines. use of ValueTracking queries. Whether this makes sense depends on the case, but it's usually a good idea to only handle the constant pattern first, and then generalize later if it seems useful. + +## Guidelines for reviewers + + * Do not ask contributors to implement non-splat vector support in code + reviews. If you think non-splat vector support for a fold is both + worthwhile and policy-compliant (that is, the handling would not result in + any appreciable increase in code complexity), implement it yourself in a + follow-up patch.