fix(rules/header): trim lead/trail whitespace #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to consider this if you add a meaningful test case, verifying what you contribute works. |
Great, will do |
|
@nikku updated to include test case that fails w/o change, and also updated docs. |
srl295
commented
Jan 13, 2022
| * | ||
| * This source code is licensed under the WTFPL license found in the | ||
| * LICENSE file in the root of this projects source tree. | ||
| */ |
Related to #5, use trim() so that trailing whitespace is corrected before test. Includes test case and doc update.
|
Thanks for your quick response. Merged with some minor adjustments via #10. |
|
@nikku welcome. Thank you for this plugin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5, use trim() so that trailing whitespace is corrected before test.
Closes #8