…ies.

This is related to the previous change to this function earlier today.

…ramiko!

Also shuffles around where the warn/hide with statement is used (should really
have been inside contains() to begin with) and updated to work correctly with
"empty" append lines -- i.e. one may use append to tack on whitespace lines if
desired.

For some dumb reason I had updated the behavior of upload_template so that it
no longer worked as advertised. In retrospect it really should work as
advertised, namely that the "destination" string is given verbatim to the call
to "cp".

This gives more power to the user, and the user may explicitly tack on
a trailing slash if they want "cp" to copy a file into a folder, as normal.

…trings.

Thanks to Evan Jones for the catch.

Tested with fresh virtualenvs doing setup.py install|develop|build. Seems to
work OK in all of them.

Signed-off-by: Jeff Forcier <jeff@bitprophet.org>

Fix bug where missing username/port threw exceptions

Signed-off-by: Jeff Forcier <jeff@bitprophet.org>

…et_pty()

Paramiko doesn't actually prompt for encrypted private keys, and also does some
silly argument overriding. End result is that non-agent-loaded private keys
*do* already work with our current logic, but we needed to detect what's going
on so we can clue the users in as to what password is being asked for.

Only behavioral change is that raised AttributeErrors are more descriptive.
Also provides small performance benefit due to not accessing dict twice.

Less hacky and more platform-agnostic.

Signed-off-by: Jeff Forcier <jeff@bitprophet.org>

…ing again.

Tested both ssh-agent and password authentication and both appear to work
correctly now.

Signed-off-by: Jeff Forcier <jeff@bitprophet.org>

Signed-off-by: Jeff Forcier <jeff@bitprophet.org>

…ld docs.