Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for other renderers than Canvas and fixed image rendering in SVG renderer #92

Merged
merged 8 commits into from May 22, 2012

Conversation

Projects
None yet
2 participants

bdkzero commented Apr 17, 2012

No description provided.

Owner

niklasvh commented Apr 25, 2012

Thanks for the pull request, I'll try and get this reviewed and merged soon!

bdkzero commented Apr 25, 2012

Thanks a lot :-)

bdkzero commented May 12, 2012

Hello,
have you tried my patch? I suppose I made a mistake sending you a pull request of my master branch.
Do you want a git-patch instead only for support other renderers (than Canvas) and fixing images SVG renderer?

Sorry,
Paolo

@niklasvh niklasvh commented on an outdated diff May 13, 2012

@@ -5,7 +5,7 @@
/tests/cache/
/tests/flashcanvas.html
/lib/
-/build/
@niklasvh

niklasvh May 13, 2012

Owner

This is left there so that the builds won't be committed with each patch. Tested and working builds can be acquired from https://github.com/niklasvh/html2canvas/downloads if they don't wish to build from source.

For more info regarding this decision, please read #28

@niklasvh niklasvh commented on an outdated diff May 13, 2012

build/jquery.plugin.html2canvas.js
@@ -0,0 +1,87 @@
@niklasvh

niklasvh May 13, 2012

Owner

see comment in .gitignore

@niklasvh niklasvh commented on an outdated diff May 13, 2012

@@ -23,6 +23,7 @@
<file name="Renderer.js"/>
<file name="Util.js"/>
<file name="renderers/Canvas.js"/>
+ <file name="renderers/SVG.js"/>
@niklasvh

niklasvh May 13, 2012

Owner

by default, we wouldn't want the SVG renderer to be included in the library though. We should probably create a new build target for it.

Owner

niklasvh commented May 13, 2012

So sorry for the very long delay, please check the the comments I added to few of the committed changes.

bdkzero commented May 13, 2012

Thankyou for your answer.
Can I commit fixes (for your comments) directly on my master branch? Is this a problem?

Owner

niklasvh commented May 13, 2012

That's fine

bdkzero commented May 20, 2012

Hi,
I've fixed reported problems. I created a new build target called 'build-allrends' to get html2canvas built with all renderers.
Is it fine?

@niklasvh niklasvh added a commit that referenced this pull request May 22, 2012

@niklasvh niklasvh Merge pull request #92 from bdkzero/master
Support for other renderers than Canvas and fixed image rendering in SVG renderer
16022b8

@niklasvh niklasvh merged commit 16022b8 into niklasvh:master May 22, 2012

Owner

niklasvh commented May 22, 2012

Nice, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment