Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state change compare to cater for objects not references #26

Merged
merged 2 commits into from Apr 9, 2019

Conversation

@WizBangCrash
Copy link
Contributor

commented Jan 6, 2019

Hi Niklas,
Found an issue when using JSON on/off payloads with the comparison used to determine when to send a state change message. The compare was only comparing object references, not the content of the object. e.g. I use {"on": true} & {"on": false} as the on/off payloads.
Pull request uses a builtin node-red library function to compare the content.
Hope this can be included in the next release.

Thanks or a very useful node :-)

WizBangCrash and others added some commits Jan 5, 2019

@niklaswall

This comment has been minimized.

Copy link
Owner

commented Apr 9, 2019

Thank you for noticing this issue! :-)

@niklaswall niklaswall merged commit 102e652 into niklaswall:master Apr 9, 2019

niklaswall added a commit that referenced this pull request Apr 9, 2019

@WizBangCrash WizBangCrash deleted the WizBangCrash:fix-compare branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.