Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDangly paths #17
Conversation
pnkfelix
added some commits
Sep 6, 2017
pnkfelix
referenced this pull request
Sep 12, 2017
Open
[borrowck] handling of drops invalidating borrows #40
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
RalfJung
Feb 5, 2018
@nikomatsakis sent me here during the recent #[may_dangle] discussion. TIL we have another soundness hole. ;)
I have one question regarding the gist you referenced:
Now, even though the destructor of MessageOnDrop2 does not access its type parameter, dropping it still drops the instance of T, which for eventually_impure means that we run the destructor of PoisonOnDrop (and thus mutate data in the reference).
So we need to be careful.
This "just" means that we have to check all the types along the path in question, right? If things are done properly structurally, recursing over the type, this should just work? Or am I missing something?
RalfJung
commented
Feb 5, 2018
|
@nikomatsakis sent me here during the recent I have one question regarding the gist you referenced:
This "just" means that we have to check all the types along the path in question, right? If things are done properly structurally, recursing over the type, this should just work? Or am I missing something? |
pnkfelix commentedSep 12, 2017
The feature being implemented here is sketched out in https://gist.github.com/pnkfelix/6df6975c99d5c4da37136ada9fa44fb0
(I still need to transcribe part of the comments in this code into that gist, analogous to the Detailed Design of an RFC.)