Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to model creation #156

Merged
merged 3 commits into from Jul 31, 2017
Merged

Add options to model creation #156

merged 3 commits into from Jul 31, 2017

Conversation

@paaddyy
Copy link
Contributor

paaddyy commented Jul 28, 2017

Project needs a new compilation - tried it in various ways on windows but nothing worked, thanks :)

Project needs a new compilation - tried it in various ways on windows but nothing worked, thanks :)
@nilbus
Copy link
Owner

nilbus commented Jul 31, 2017

Nice. Have you tested and found this to resolve your problem?

@@ -393,7 +393,7 @@ as that.
if (model) {
responseModel = modelUpdatedWithResponse(model, modelAttributes);
} else {
responseModel = new collection.model(modelAttributes);
responseModel = new collection.model(modelAttributes, options);

This comment has been minimized.

@houndci-bot

houndci-bot Jul 31, 2017 Collaborator

Line is too long.

@nilbus
Copy link
Owner

nilbus commented Jul 31, 2017

Seems to me like it should. Thanks! :-)

@nilbus nilbus merged commit ce4199b into nilbus:master Jul 31, 2017
1 check passed
1 check passed
hound No violations found. Woof!
@paaddyy
Copy link
Contributor Author

paaddyy commented Jul 31, 2017

thanks for merging and compiling :)
like your repo, does a great job in my project :)

@nilbus
Copy link
Owner

nilbus commented Jul 31, 2017

@paaddyy Glad to hear! You certainly made it easy with your PR. How long have you been using it? I have been wondering if there are any new users, with React taking over the world these days.

@paaddyy
Copy link
Contributor Author

paaddyy commented Jul 31, 2017

Haha, I never tried React :D I think I'll give Vue a chance within the next days, seems it has the potential to combine all the best features from Angular and React. Do you still use Backbone or have you changed your "stack" too? :)

I'm using it at work for three weeks now. At the moment only for local storage but within the next few weeks also for server sync. I'm excited if everthing works directly :P

@nilbus
Copy link
Owner

nilbus commented Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.