Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dtype option to the maskers #1669

Closed
GaelVaroquaux opened this issue Jul 2, 2018 · 1 comment
Closed

Add a dtype option to the maskers #1669

GaelVaroquaux opened this issue Jul 2, 2018 · 1 comment
Labels
Enhancement for feature requests Good first issue Good for newcomers. Equivalent to "very low" effort.

Comments

@GaelVaroquaux
Copy link
Member

We should add a dtype option to the different masker object (NiftiMasker, MultiNiftiMasker...) to control the dtype of the output array.

dtype=None would respect the type of the input data.

In the long run, we should switch the default to dtype=np.float32 to decrease the memory usage.
@GaelVaroquaux GaelVaroquaux added the Enhancement for feature requests label Jul 2, 2018
@GaelVaroquaux GaelVaroquaux added the Good first issue Good for newcomers. Equivalent to "very low" effort. label Jul 25, 2018
@SylvainLan SylvainLan mentioned this issue Jul 31, 2018
Merged
@KamalakerDadi
Copy link
Contributor

Closing with #1711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement for feature requests Good first issue Good for newcomers. Equivalent to "very low" effort.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GaelVaroquaux @KamalakerDadi