Deprecate leiningen and rehydrate deps #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitallis
commented
Jan 29, 2021
| @@ -1,6 +1,6 @@ | |||
| (ns honeysql-postgres.helpers | |||
| (:refer-clojure :exclude [partition-by]) | |||
| (:require [honeysql-postgres.format :refer :all] | |||
Contributor
Author
There was a problem hiding this comment.
We need to do this because:
clj-kondodoes not like:refer :all- ClojureScript does not support
:refer :all, but we do test against it (as we should)
scimetfoo
reviewed
Jan 29, 2021
| "-d" "test"]} | ||
| :cljs-runner {:extra-deps {olical/cljs-test-runner {:mvn/version "3.8.0"}} | ||
| :main-opts ["-m" "cljs-test-runner.main"]} | ||
| :jar {:replace-deps {seancorfield/depstar {:mvn/version "2.0.165"}} |
Contributor
There was a problem hiding this comment.
What's the rationale for having both a :depstar alias and a :jar alias? Wouldn't the :depstar alias alone suffice for creating both uberjars and jars?
Contributor
Author
There was a problem hiding this comment.
Removed the depstar alias. I'm thinking, since this is a library, we shouldn't really need to build an uberjar. Thin jar should suffice.
scimetfoo
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the conversation in #46 (comment).
clj -M:test:runnerfor running testsclj -M:test:cljs-runnerfor running tests against ClojureScriptclj -X:jar :jar honeysql-postgres.jarfor building a thin library jar