Skip to content

Deprecate leiningen and rehydrate deps #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2021
Merged

Deprecate leiningen and rehydrate deps #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfe6a6a
Add tests + jar building to deps
kitallis Jan 28, 2021
b73d9f5
Add cljs runner
kitallis Jan 28, 2021
aa557c7
Remove project.clj (lein)
kitallis Jan 29, 2021
59df870
Add jar building via exec-fn
kitallis Jan 29, 2021
dc0b174
Remove depstar alias
kitallis Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion deps.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,13 @@
{:deps {honeysql {:mvn/version "0.9.5" :exclusions [org.clojure/clojurescript]}}}
{:deps {honeysql/honeysql {:mvn/version "0.9.5" :exclusions [org.clojure/clojurescript]}}
:paths ["src"]
:aliases {:test {:extra-paths ["test"]}
:runner {:extra-deps {com.cognitect/test-runner
{:git/url "https://github.com/cognitect-labs/test-runner"
:sha "b6b3193fcc42659d7e46ecd1884a228993441182"}}
:main-opts ["-m" "cognitect.test-runner"
"-d" "test"]}
:cljs-runner {:extra-deps {olical/cljs-test-runner {:mvn/version "3.8.0"}}
:main-opts ["-m" "cljs-test-runner.main"]}
:jar {:replace-deps {seancorfield/depstar {:mvn/version "2.0.165"}}
Copy link
Contributor

@scimetfoo scimetfoo Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for having both a :depstar alias and a :jar alias? Wouldn't the :depstar alias alone suffice for creating both uberjars and jars?

Copy link
Contributor Author

@kitallis kitallis Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the depstar alias. I'm thinking, since this is a library, we shouldn't really need to build an uberjar. Thin jar should suffice.

:exec-fn hf.depstar/jar
:exec-args {}}}}
13 changes: 0 additions & 13 deletions project.clj
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/honeysql_postgres/helpers.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
(ns honeysql-postgres.helpers
(:refer-clojure :exclude [partition-by])
(:require [honeysql-postgres.format :refer :all]
Copy link
Contributor Author

@kitallis kitallis Jan 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do this because:

  • clj-kondo does not like :refer :all
  • ClojureScript does not support :refer :all, but we do test against it (as we should)

(:require [honeysql-postgres.format]
[honeysql.helpers :as sqlh #?(:clj :refer :cljs :refer-macros) [defhelper]]))

;; Extension of the honeysql helper funcitons for postgreSQL
Expand Down