Skip to content

(#167) add a check of the registry #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nils-a merged 1 commit into from
Oct 4, 2023
Merged

(#167) add a check of the registry #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
189 changes: 94 additions & 95 deletions src/JavaVersionSwitcher.Tests/ConfigurationServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,119 +6,118 @@
using Shouldly;
using Xunit;

namespace JavaVersionSwitcher.Tests
namespace JavaVersionSwitcher.Tests;

public class ConfigurationServiceTests
{
public class ConfigurationServiceTests
[Fact]
public async Task SetConfiguration_throws_on_wrong_provider()
{
[Fact]
public async Task SetConfiguration_throws_on_wrong_provider()
{
// arrange
using var fixture = new ConfigurationServiceFixture();
const string providerName = "non-existent-provider";
// arrange
using var fixture = new ConfigurationServiceFixture();
const string providerName = "non-existent-provider";

// act
// ReSharper disable once AccessToDisposedClosure
async Task Act() => await fixture.Service.SetConfiguration(providerName, null, null);
// act
// ReSharper disable once AccessToDisposedClosure
async Task Act() => await fixture.Service.SetConfiguration(providerName, null, null);

// assert
(await Should.ThrowAsync<KeyNotFoundException>((Func<Task>)Act))
.Message
.ShouldSatisfyAllConditions(
m => m.ShouldStartWith("No ConfigurationProvider"),
m => m.ShouldContain(providerName));
}
// assert
(await Should.ThrowAsync<KeyNotFoundException>((Func<Task>)Act))
.Message
.ShouldSatisfyAllConditions(
m => m.ShouldStartWith("No ConfigurationProvider"),
m => m.ShouldContain(providerName));
}

[Fact]
public async Task SetConfiguration_throws_on_wrong_setting()
{
// arrange
const string providerName = "provider";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName);
const string setting = "non-existent-setting";
[Fact]
public async Task SetConfiguration_throws_on_wrong_setting()
{
// arrange
const string providerName = "provider";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName);
const string setting = "non-existent-setting";

// act'
// ReSharper disable once AccessToDisposedClosure
async Task Act() => await fixture.Service.SetConfiguration(providerName, setting, null);
// act'
// ReSharper disable once AccessToDisposedClosure
async Task Act() => await fixture.Service.SetConfiguration(providerName, setting, null);

// assert
(await Should.ThrowAsync<KeyNotFoundException>((Func<Task>)Act))
.Message
.ShouldSatisfyAllConditions(
m => m.ShouldStartWith("No Configuration with the name"),
m => m.ShouldContain(setting));
}
// assert
(await Should.ThrowAsync<KeyNotFoundException>((Func<Task>)Act))
.Message
.ShouldSatisfyAllConditions(
m => m.ShouldStartWith("No Configuration with the name"),
m => m.ShouldContain(setting));
}

[Fact]
public async Task SetConfiguration_writes_value_to_xml()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
const string value = "a value";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);
[Fact]
public async Task SetConfiguration_writes_value_to_xml()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
const string value = "a value";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);

// act'
await fixture.Service.SetConfiguration(providerName, settingsName, value);
// act'
await fixture.Service.SetConfiguration(providerName, settingsName, value);

// assert
var xml = fixture.ReadXml(providerName, settingsName);
xml.Value.ShouldBe(value);
}
// assert
var xml = fixture.ReadXml(providerName, settingsName);
xml.Value.ShouldBe(value);
}

[Fact]
public async Task GetConfiguration_returns_empty_for_not_set_setting()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);
[Fact]
public async Task GetConfiguration_returns_empty_for_not_set_setting()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);

// act'
var actual = await fixture.Service.GetConfiguration(providerName, settingsName);
// act'
var actual = await fixture.Service.GetConfiguration(providerName, settingsName);

// assert
actual.ShouldBe(string.Empty);
}
// assert
actual.ShouldBe(string.Empty);
}

[Fact]
public async Task GetConfiguration_returns_the_value_from_xml()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
const string expected = "some value";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);
fixture.EnsureSetting(providerName, settingsName, expected);
[Fact]
public async Task GetConfiguration_returns_the_value_from_xml()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
const string expected = "some value";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);
fixture.EnsureSetting(providerName, settingsName, expected);

// act'
var actual = await fixture.Service.GetConfiguration(providerName, settingsName);
// act'
var actual = await fixture.Service.GetConfiguration(providerName, settingsName);

// assert
actual.ShouldBe(expected);
}
// assert
actual.ShouldBe(expected);
}

[Fact]
public async Task SetConfiguration_removes_empty_settings()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);
fixture.EnsureSetting(providerName, settingsName, "some value");
[Fact]
public async Task SetConfiguration_removes_empty_settings()
{
// arrange
const string providerName = "pName";
const string settingsName = "settingsName";
using var fixture = new ConfigurationServiceFixture();
fixture.WithConfigurationProvider(providerName, settingsName);
fixture.EnsureSetting(providerName, settingsName, "some value");

// act'
await fixture.Service.SetConfiguration(providerName, settingsName, null);
// act'
await fixture.Service.SetConfiguration(providerName, settingsName, null);

// assert
var xml = fixture.ReadXml();
xml.Parent.ShouldBeNull("this should be the root node.");
xml.Elements().Count().ShouldBe(0);
}
// assert
var xml = fixture.ReadXml();
xml.Parent.ShouldBeNull("this should be the root node.");
xml.Elements().Count().ShouldBe(0);
}
}
73 changes: 36 additions & 37 deletions src/JavaVersionSwitcher.Tests/Fixtures/CommandFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,56 +8,55 @@
using Spectre.Console.Cli;
using Spectre.Console.Testing;

namespace JavaVersionSwitcher.Tests.Fixtures
namespace JavaVersionSwitcher.Tests.Fixtures;

public class CommandFixture
{
public class CommandFixture
public CommandFixture()
{
public CommandFixture()
{
Logger = new Logger(Console);
}
Logger = new Logger(Console);
}

public TestConsole Console { get; } = new TestConsole();
public TestConsole Console { get; } = new TestConsole();

public Logger Logger { get; }
public Logger Logger { get; }

public TestConfigurationService ConfigurationService { get; } = new TestConfigurationService();
public TestConfigurationService ConfigurationService { get; } = new TestConfigurationService();

public Mock<IJavaHomeAdapter> JavaHomeAdapter { get; } = new Mock<IJavaHomeAdapter>();
public Mock<IJavaHomeAdapter> JavaHomeAdapter { get; } = new Mock<IJavaHomeAdapter>();

public Mock<IPathAdapter> PathAdapter { get; } = new Mock<IPathAdapter>();
public Mock<IPathAdapter> PathAdapter { get; } = new Mock<IPathAdapter>();

public Mock<IJavaInstallationsAdapter> JavaInstallationsAdapter { get; } = new Mock<IJavaInstallationsAdapter>();
public Mock<IJavaInstallationsAdapter> JavaInstallationsAdapter { get; } = new Mock<IJavaInstallationsAdapter>();

private ITypeRegistrar BuildRegistrar()
{
var container = new Container();
container.RegisterInstance<ILogger>(Logger);
container.RegisterInstance<IConfigurationService>(ConfigurationService);
container.RegisterInstance(JavaHomeAdapter.Object);
container.RegisterInstance(PathAdapter.Object);
container.RegisterInstance(JavaInstallationsAdapter.Object);
private ITypeRegistrar BuildRegistrar()
{
var container = new Container();
container.RegisterInstance<ILogger>(Logger);
container.RegisterInstance<IConfigurationService>(ConfigurationService);
container.RegisterInstance(JavaHomeAdapter.Object);
container.RegisterInstance(PathAdapter.Object);
container.RegisterInstance(JavaInstallationsAdapter.Object);

container.Register<JavaInstallationsAdapterConfigurationProvider>(Lifestyle.Singleton);
container.Register<JavaInstallationsAdapterConfigurationProvider>(Lifestyle.Singleton);

container.Collection.Register<IConfigurationProvider>(
new[]
{
typeof(JavaInstallationsAdapterConfigurationProvider),
},
Lifestyle.Singleton);
container.Collection.Register<IConfigurationProvider>(
new[]
{
typeof(JavaInstallationsAdapterConfigurationProvider),
},
Lifestyle.Singleton);

return new SimpleInjectorRegistrar(container);
}
return new SimpleInjectorRegistrar(container);
}

public int Run(params string[] args)
{
AnsiConsole.Console = Console;
var registrar = BuildRegistrar();
var app = new CommandApp(registrar);
app.Configure(Program.ConfigureApp);
public int Run(params string[] args)
{
AnsiConsole.Console = Console;
var registrar = BuildRegistrar();
var app = new CommandApp(registrar);
app.Configure(Program.ConfigureApp);

return app.Run(args);
}
return app.Run(args);
}
}
Loading